SK-147 / add e2e test using simkube-ci-action #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 75.60% 75.60%
=======================================
Files 58 58
Lines 3291 3291
Branches 164 164
=======================================
Hits 2488 2488
Misses 697 697
Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ogorman89
changed the title
drmorr0
approved these changes
Jan 22, 2026
.github/workflows/simkube_e2e.yml
Outdated
| - name: Setup SimKube GitHub Action runner | ||
| uses: acrlabs/simkube-ci-action/actions/launch-runner@main | ||
| with: | ||
| ami-id: ami-03e5877b8398d4577 |
Contributor
There was a problem hiding this comment.
nit for the future: is it possible to reference the latest AMI from the parameter store, instead of hard-coding here?
Contributor
Author
There was a problem hiding this comment.
Added a todo, I think I want to make this the default behavior in the simkube-ci-action repo but allow overrides.
.github/workflows/simkube_e2e.yml
Outdated
| uses: acrlabs/simkube-ci-action/actions/launch-runner@main | ||
| with: | ||
| ami-id: ami-03e5877b8398d4577 | ||
| instance-type: c7a.xlarge |
Contributor
There was a problem hiding this comment.
Let's maybe use an m6a.large here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Links
Description and Rationale
How
launch-runneraction launches an ephemeral runner in the users AWS account (ACRL's AWS account in this case) that listens for jobs and runs one jobrun-simulationaction launches a simulation on an available custom SimKube runner using an available traceTest Steps
Other Notes
Our custom actions expose only a basic set of simulation parameters. In the future I expect to expose more functionality in the actions. The runner AMI is fully capable of running any SimKube simulation. If you can do it in SimKube you can do it on the runner!
[ ✅ ] I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.