Skip to content

Conversation

@drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Jan 29, 2026

Related Links

Description and Rationale

  • Add nodeSelector and tolerations at the podTemplateSpec level for simulated objects: DaemonSets (for example) use these fields to figure out how many pods to run, so if they're not set, then we won't schedule the right number of DaemonSet pods.

Test Steps

  • Adding some new tests for some mildly cursed boolean logic

  • manual testing

  • I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.75%. Comparing base (da7884b) to head (51df7f5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sk-driver/src/runner.rs 77.77% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   75.60%   75.75%   +0.15%     
==========================================
  Files          58       58              
  Lines        3291     3316      +25     
  Branches      164      165       +1     
==========================================
+ Hits         2488     2512      +24     
- Misses        697      699       +2     
+ Partials      106      105       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drmorr0 drmorr0 merged commit 78127ed into main Jan 29, 2026
7 checks passed
@drmorr0 drmorr0 deleted the push-nnvqsmpkvsqt branch January 29, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants