support rc version such as go 1.26rc1
#702
Open
+109
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for Go's RC version format (e.g., go 1.26rc1) by introducing a normalizeVersionSpec() function that converts Go-style prerelease versions to semver format before matching.
Key Changes:
- Added
normalizeVersionSpec()function to convert Go-style prerelease notation (e.g.,1.14rc1) to semver format (e.g.,1.14.0-rc.1) - Updated
findMatch()to normalize version specs before matching against available Go versions - Added integration tests to verify Go-style RC version resolution
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/installer.ts | Implements normalizeVersionSpec() function and integrates it into the version matching logic |
| dist/setup/index.js | Compiled JavaScript output reflecting the TypeScript changes |
| tests/setup-go.test.ts | Adds integration tests for Go-style RC version matching with and without range operators |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gfx
force-pushed
the
gfx/support-1.26rc1
branch
from
1b06a08 to
f63b7ec
Compare
gfx
force-pushed
the
gfx/support-1.26rc1
branch
from
f63b7ec to
f5562dd
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
actions/go-setupcannot installgo1.26rc1:https://github.com/sqldef/sqldef/actions/runs/20521055234/job/58956343695?pr=1066
This PR fixes it by introducing
normalizeVersionSpec().With this PR, setup-go can install
1.26rc1: https://github.com/sqldef/sqldef/actions/runs/20523447714/job/58962500134?pr=1066Related issue:
(none)
Check list: