Skip to content

TextBox show when empty #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FoamyGuy merged 2 commits into from
Dec 12, 2025
Merged

TextBox show when empty #233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
469e24d
TextBox show when empty
FoamyGuy Dec 12, 2025
f049812
always show textbox when empty
FoamyGuy Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions adafruit_display_text/text_box.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,12 @@ class TextBox(bitmap_label.Label):
DYNAMIC_HEIGHT = const(-1)

def __init__(
self, font: FontProtocol, width: int, height: int, align=ALIGN_LEFT, **kwargs
self,
font: FontProtocol,
width: int,
height: int,
align=ALIGN_LEFT,
**kwargs,
) -> None:
self._bitmap = None
self._tilegrid = None
Expand Down Expand Up @@ -238,23 +243,9 @@ def _reset_text(
self._text = self._replace_tabs(text)

# Check for empty string
if (not text) or (
text is None
): # If empty string, just create a zero-sized bounding box and that's it.
self._bounding_box = (
0,
0,
0, # zero width with text == ""
0, # zero height with text == ""
)
# Clear out any items in the self._local_group Group, in case this is an
# update to the bitmap_label
for _ in self._local_group:
self._local_group.pop(0)

# Free the bitmap and tilegrid since they are removed
self._bitmap = None
self._tilegrid = None
if (not text) or (text is None):
# clear the existing bitmap and keep it
self._bitmap.fill(0)

else: # The text string is not empty, so create the Bitmap and TileGrid and
# append to the self Group
Expand Down