Skip to content

Fix: Compilation issues and linting (fixes #137) #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joe-allen-89 merged 1 commit into from
Mar 31, 2025
Merged

Fix: Compilation issues and linting (fixes #137) #138

joe-allen-89 merged 1 commit into from
Mar 31, 2025

Conversation

@oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Feb 19, 2025

fixes #137

Fix

  • Added async keyword on sendStateToServer
  • Fixed undefined variables throughout
  • Linted for let vs const, extra commas, spacing, etc

@oliverfoster oliverfoster self-assigned this Feb 19, 2025
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit dca723c into master Mar 31, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Mar 31, 2025
github-actions bot pushed a commit that referenced this pull request Mar 31, 2025
@semantic-release-bot
Chore(release): 1.2.2 [skip ci]
081f190 
## [1.2.2](v1.2.1...v1.2.2) (2025-03-31)

### Chore

* Add support for new issue experience (fixes #136) (#139) ([b305ddb](b305ddb)), closes [#136](#136) [#139](#139)

### Fix

* Compilation issues and linting (fixes #137) (#138) ([dca723c](dca723c)), closes [#137](#137) [#138](#138)
@github-actions
Copy link

github-actions bot commented Mar 31, 2025

🎉 This PR is included in version 1.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@oliverfoster oliverfoster

Labels

bug ready to release released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compilation is broken

4 participants

@oliverfoster @cahirodoherty-learningpool @joe-allen-89