Skip to content

Handling system tables errors #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chanukya571 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handling system tables errors #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e463b81
error messages for system tables to use VACUUM FULL.
chanukya571 Dec 20, 2022
2fb3261
code alignment
chanukya571 Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions bin/pg_repack.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ typedef struct repack_table

static bool is_superuser(void);
static void check_tablespace(void);
static bool check_systemtables(void);
static bool preliminary_checks(char *errbuf, size_t errsize);
static bool is_requested_relation_exists(char *errbuf, size_t errsize);
static void repack_all_databases(const char *order_by);
Expand Down Expand Up @@ -421,6 +422,47 @@ is_superuser(void)
return false;
}

bool
check_systemtables()

{
PGresult *query_result = NULL;
int num;
SimpleStringListCell *cell;
StringInfoData sql;
int iparam = 0;

num = simple_string_list_size(table_list);

initStringInfo(&sql);

appendStringInfoString(&sql, "select 1 from pg_class c JOIN pg_namespace n ON n.oid = c.relnamespace where n.nspname IN ('pg_catalog','information_schema') AND c.oid IN (");

for (cell = table_list.head; cell; cell = cell->next)
{
appendStringInfo(&sql, "'%s'::regclass::oid", cell->val);
iparam++;
if (iparam < num)
appendStringInfoChar(&sql, ',');
}

appendStringInfoString(&sql,")");

query_result = execute_elevel(sql.data,0,NULL, DEBUG2);

if (PQresultStatus(query_result) == PGRES_TUPLES_OK)
{
if (PQntuples(query_result) >= 1)
{
return true;
}
}

CLEARPGRES(query_result);

return false;
}

/*
* Check if the tablespace requested exists.
*
Expand Down Expand Up @@ -487,6 +529,12 @@ preliminary_checks(char *errbuf, size_t errsize){
goto cleanup;
}

if (check_systemtables()) {
if (errbuf)
snprintf(errbuf, errsize, "For System Tables Use VACUUM FULL.");
goto cleanup;
}

/* Query the extension version. Exit if no match */
res = execute_elevel("select repack.version(), repack.version_sql()",
0, NULL, DEBUG2);
Expand Down