Skip to content

GH-249 leveraging the retry-after header support of Feign in our IOErrorDecoder #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoisledroff merged 1 commit into from
Sep 17, 2025
Merged

GH-249 leveraging the retry-after header support of Feign in our IOErrorDecoder #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions core/src/main/java/com/adobe/aio/util/feign/IOErrorDecoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,22 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class IOErrorDecoder implements ErrorDecoder {
public class IOErrorDecoder extends ErrorDecoder.Default implements ErrorDecoder {

public static final String REQUEST_ID = "x-request-id";

private final Logger logger = LoggerFactory.getLogger(this.getClass());

public IOErrorDecoder() {
super();
}

@Override
public Exception decode(String methodKey, Response response) {
FeignException exception = FeignException.errorStatus(methodKey, response);
logger.warn("Upstream response error ({},{})", response.status(), exception.contentUTF8());
return (response.status() >= 500) ?
new IOUpstreamError(response, exception, getRequestId(response.headers())) : exception;
new IOUpstreamError(response, exception, getRequestId(response.headers())) : super.decode(methodKey, response);
}

private String getRequestId(Map<String, Collection<String>> headers) {
Expand Down