fix: fetch api key from s3 and fix invalidation sequence #1251
Conversation
|
This PR will trigger a patch release when merged. |
| export function calculateForwardedHost(url, logger = console) { | ||
| try { | ||
| const urlObj = new URL(url); | ||
| const forwardedHost = urlObj.hostname.replace(/^www\./, ''); |
There was a problem hiding this comment.
forwarded host is typica lly of format: www.adobe.com where apex domain is there, else it is with subdomain, like: blog.adobe.com
|
|
||
| it('should remove www prefix from hostname', async () => { | ||
| const result = calculateForwardedHost('https://www.example.com/page', log); | ||
| expect(result).to.equal('example.com'); |
| }); | ||
|
|
||
| it('should remove www prefix from hostname', async () => { | ||
| const result = calculateForwardedHost('https://www.example.com/page', log); |
There was a problem hiding this comment.
if its https://example.com/page, then forwarded host should be: www.example.com
| }).optional(), | ||
| tokowakaConfig: Joi.object({ | ||
| apiKey: Joi.string().required(), | ||
| apiKey: Joi.string().optional(), |
There was a problem hiding this comment.
This would need enabled prop and removal of the existing props (step wise)
There was a problem hiding this comment.
Yes, this will be fixed in the next related issue I am picking tomorrow.
# [@adobe/spacecat-shared-data-access-v2.92.1](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v2.92.0...@adobe/spacecat-shared-data-access-v2.92.1) (2026-01-07) ### Bug Fixes * fetch api key from s3 and fix invalidation sequence ([#1251](#1251)) ([fe66bd6](fe66bd6))
|
🎉 This PR is included in version @adobe/spacecat-shared-data-access-v2.92.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [@adobe/spacecat-shared-tokowaka-client-v1.4.5](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-tokowaka-client-v1.4.4...@adobe/spacecat-shared-tokowaka-client-v1.4.5) (2026-01-07) ### Bug Fixes * fetch api key from s3 and fix invalidation sequence ([#1251](#1251)) ([fe66bd6](fe66bd6))
|
🎉 This PR is included in version @adobe/spacecat-shared-tokowaka-client-v1.4.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes https://github.com/adobe-rnd/tokowaka-worker/issues/455, https://github.com/adobe-rnd/tokowaka-worker/issues/459