feat: add tryValidateUsing to HttpRequest #5034
Conversation
| const data = validatorOptions.data || { | ||
| ...requestBody, | ||
| params: this.#ctx.request.params(), | ||
| headers: this.#ctx.request.headers(), | ||
| cookies: this.#ctx.request.cookiesList(), | ||
| } | ||
| const data = validatorOptions.data || this.requestData() |
There was a problem hiding this comment.
@thetutlage I was a little unsure about what this was actually used for here? It feels like validatorOptions.data should be merged with the requestBody, params, headers, cookies, etc? But the original code was replacing the request data with the validator options data.
I'm not sure why you'd do request.validateUsing(myValidator, { data: { foo: 'bar' } }) where the request isn't even factored into the validation? Wouldn't you just do myValidator.validate({ foo: 'bar' }) for that? Or is this to have the error reporter and messages provider setup still when not actually validating a request?
There was a problem hiding this comment.
Yes, the data property is used to specify your own custom data without performing any merging under the hood.
The request validator can still be helpful, because (as you mentioned) it allows for using correct messages provider and the error reporter. Also, sometimes its more about uniformity as well
There was a problem hiding this comment.
Okay, cool, just wanted to verify this behavior was definitely the expected behavior here
2 participants
🔗 Linked issue
I didn't create an issue first, but this was a feature added in Vine.js back in June 2024.
❓ Type of change
📚 Description
Sometimes when validating requests, you just want to attempt to validate the request, but then handle the errors yourself, instead of having them propagate upwards out of your controller.
This adds support for
validator.tryValidatefrom Vine.js to theHttpRequestastryValidateUsing.📝 Checklist
This will require a documentation change, if we agree this is a good feature to have.