Skip to content

Conversation

@NakoGH
Copy link
Contributor

@NakoGH NakoGH commented Dec 13, 2025

Description

Summary

...

Issues/PR dependencies

Issues to be resolved

Required PRs

Changes Made

  • ...
  • ...

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@NakoGH NakoGH self-assigned this Dec 13, 2025
@codecov
Copy link

codecov bot commented Dec 13, 2025

Codecov Report

❌ Patch coverage is 89.87342% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.92%. Comparing base (5fd6ace) to head (f54f5aa).

Files with missing lines Patch % Lines
app/core/myeclpay/cruds_myeclpay.py 88.00% 3 Missing ⚠️
app/core/myeclpay/endpoints_myeclpay.py 88.88% 3 Missing ⚠️
app/core/myeclpay/utils/data_exporter.py 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #927      +/-   ##
==========================================
+ Coverage   84.86%   84.92%   +0.06%     
==========================================
  Files         193      194       +1     
  Lines       13888    13966      +78     
==========================================
+ Hits        11786    11861      +75     
- Misses       2102     2105       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rotheem Rotheem force-pushed the myeclpay-csv-export branch 2 times, most recently from d30aace to 37f9ae5 Compare December 31, 2025 17:47
@Rotheem Rotheem force-pushed the myeclpay-csv-export branch from 37f9ae5 to 321de9c Compare December 31, 2025 18:15
Comment on lines +676 to +681
transactions_with_sellers = []
for row in result.all():
transaction = row[0]
user = row[1]

transactions_with_sellers.append((transaction, user.full_name))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can unpack (do destructuring) in Python on sequences too:

transaction, user, _ = row

@Marc-Andrieu Marc-Andrieu merged commit 61a12ce into main Dec 31, 2025
5 of 6 checks passed
@Marc-Andrieu Marc-Andrieu deleted the myeclpay-csv-export branch December 31, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants