Skip to content

Conversation

@juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Jan 21, 2026

Docs

https://aerospike-python-client--928.org.readthedocs.build/en/928/aerospike.html#aerospike.get_partition_id

Extra changes

Add missing test cases for aerospike.get_partition_id()

This allows digests containing a NULL character to be passed to this helper API

TODO

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.35%. Comparing base (144f859) to head (3799fbe).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/calc_digest.c 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #928      +/-   ##
==========================================
+ Coverage   83.31%   83.35%   +0.03%     
==========================================
  Files          99       99              
  Lines       14422    14434      +12     
==========================================
+ Hits        12016    12031      +15     
+ Misses       2406     2403       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliannguyen4 juliannguyen4 changed the title [CLIENT-4086] Have aerospike.get_partition_id() take in a bytearray as argument instead of str [CLIENT-4086] Have aerospike.get_partition_id() take in a bytearray as argument instead of a tuple containing a str Jan 21, 2026
@juliannguyen4 juliannguyen4 changed the title [CLIENT-4086] Have aerospike.get_partition_id() take in a bytearray as argument instead of a tuple containing a str [CLIENT-4086] (Breaking change) Add missing documentation for aerospike.get_partition_id(). Have aerospike.get_partition_id() take in a bytearray as argument instead of a tuple containing a str. Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants