-
Notifications
You must be signed in to change notification settings - Fork 1
Updated biome on templates to v2 #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughBiome config schemas upgraded to 2.2.2, top-level Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
package.json (1)
15-15: Pinning Biome to an exact version is good; consider adding a unified check script.Locking to 2.2.2 keeps config/schema behavior stable. Optionally add an npm script like
biome check --error-on-warningsto run formatter, linter, and assists together. Pinning is also what Biome recommends. (v1.biomejs.dev)common/js/biome.json (2)
2-4: Correct v2 nested config + assist usage; optionally inherit root with extends.
root: falseis required for nested configs in Biome v2. ✔️ (biomejs.dev)assist.actions.source.organizeImports: "on"is the right v2 form. ✔️ (biomejs.dev)- If this file should inherit root settings, add
extends: "//":{ - "root": false, + "root": false, + "extends": "//", "$schema": "https://biomejs.dev/schemas/2.2.2/schema.json", "assist": { "actions": { "source": { "organizeImports": "on" } } },
24-24: Includes pattern is valid; consider excluding node_modules too.
files.includessupports negations and your["**", "!**/.agentuity/**"]works. Since VCS ignore integration is off by default, add!**/node_modules/**(and optionally!**/dist/**) to avoid traversing them. (biomejs.dev)biome.json (1)
23-23: Includes pattern is fine; optionally hard-exclude bulky folders.To keep templates snappy, consider adding
!**/node_modules/**(and!**/dist/**) here; VCS ignore isn’t used unless enabled. (biomejs.dev)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
biome.json(2 hunks)common/js/biome.json(2 hunks)package.json(1 hunks)
🔇 Additional comments (1)
biome.json (1)
2-3: Schema bump + assist switch look correct for v2.Using the 2.2.2 schema and
assist.actions.source.organizeImports: "on"matches Biome v2 guidance. (biomejs.dev)
package.json
Outdated
| "license": "Apache-2.0", | ||
| "devDependencies": { | ||
| "@biomejs/biome": "^1.9.4" | ||
| "@biomejs/biome": "2.2.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we make a range instead of pinning to a specific version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the problem with a range is that then the schema doesn't match and can error out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcongrove Is right, this is what I did, the biomeJS official docs also suggest pinning a specific version. https://biomejs.dev/internals/versioning/#why-pinning-the-version-is-important
| "enabled": true | ||
| }, | ||
| "$schema": "https://biomejs.dev/schemas/2.2.2/schema.json", | ||
| "assist": { "actions": { "source": { "organizeImports": "on" } } }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been... Biome formatted? ;)
Summary by CodeRabbit