Skip to content

Conversation

@Huijiro
Copy link
Member

@Huijiro Huijiro commented Aug 27, 2025

Summary by CodeRabbit

  • Chores
    • Upgraded development tooling/schema to a newer, locked version for reproducible builds.
    • Enabled automatic organize-imports behavior and refined repository file inclusion/exclusion patterns.
    • Aligned dev tooling configuration across the project for more consistent developer and CI behavior.
    • No user-facing changes; runtime functionality and public APIs remain unaffected.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 27, 2025

Walkthrough

Biome config schemas upgraded to 2.2.2, top-level organizeImports replaced by an assist.actions.source.organizeImports: "on" structure, files.ignore replaced with files.includes (with explicit exclusions), and @biomejs/biome devDependency updated to 2.2.2.

Changes

Cohort / File(s) Change Summary
Root Biome config
biome.json
$schema bumped to https://biomejs.dev/schemas/2.2.2/schema.json; legacy top-level organizeImports removed and replaced with assist.actions.source.organizeImports: "on"; files.ignorefiles.includes with patterns like ["**", "!**/.agentuity", "!**/common/js"]; other settings unchanged.
Nested Biome config
common/js/biome.json
$schema updated to 2.2.2; added top-level assist with actions.source.organizeImports: "on" and removed legacy organizeImports; files.ignorefiles.includes using ["**", "!**/.agentuity"]; root: false present; other sections unchanged.
Dev dependency update
package.json
DevDependency @biomejs/biome updated from ^1.9.4 to ^2.2.2; no other package changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my paws—configs realigned,
Imports tucked in an assist-defined bind.
Patterns include the wide, exclude the small,
.agentuity hides behind the wall.
Biome hops to 2.2.2—joyful and kind 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e419607 and 352c9fc.

📒 Files selected for processing (1)
  • package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch grodrigues/agent-558-templates

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
package.json (1)

15-15: Pinning Biome to an exact version is good; consider adding a unified check script.

Locking to 2.2.2 keeps config/schema behavior stable. Optionally add an npm script like biome check --error-on-warnings to run formatter, linter, and assists together. Pinning is also what Biome recommends. (v1.biomejs.dev)

common/js/biome.json (2)

2-4: Correct v2 nested config + assist usage; optionally inherit root with extends.

  • root: false is required for nested configs in Biome v2. ✔️ (biomejs.dev)
  • assist.actions.source.organizeImports: "on" is the right v2 form. ✔️ (biomejs.dev)
  • If this file should inherit root settings, add extends: "//":
 {
-  "root": false,
+  "root": false,
+  "extends": "//",
   "$schema": "https://biomejs.dev/schemas/2.2.2/schema.json",
   "assist": { "actions": { "source": { "organizeImports": "on" } } },

24-24: Includes pattern is valid; consider excluding node_modules too.

files.includes supports negations and your ["**", "!**/.agentuity/**"] works. Since VCS ignore integration is off by default, add !**/node_modules/** (and optionally !**/dist/**) to avoid traversing them. (biomejs.dev)

biome.json (1)

23-23: Includes pattern is fine; optionally hard-exclude bulky folders.

To keep templates snappy, consider adding !**/node_modules/** (and !**/dist/**) here; VCS ignore isn’t used unless enabled. (biomejs.dev)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 02b1307 and 5051a39.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • biome.json (2 hunks)
  • common/js/biome.json (2 hunks)
  • package.json (1 hunks)
🔇 Additional comments (1)
biome.json (1)

2-3: Schema bump + assist switch look correct for v2.

Using the 2.2.2 schema and assist.actions.source.organizeImports: "on" matches Biome v2 guidance. (biomejs.dev)

package.json Outdated
"license": "Apache-2.0",
"devDependencies": {
"@biomejs/biome": "^1.9.4"
"@biomejs/biome": "2.2.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make a range instead of pinning to a specific version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem with a range is that then the schema doesn't match and can error out

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcongrove Is right, this is what I did, the biomeJS official docs also suggest pinning a specific version. https://biomejs.dev/internals/versioning/#why-pinning-the-version-is-important

"enabled": true
},
"$schema": "https://biomejs.dev/schemas/2.2.2/schema.json",
"assist": { "actions": { "source": { "organizeImports": "on" } } },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been... Biome formatted? ;)

@Huijiro Huijiro merged commit f48a3a6 into main Sep 5, 2025
4 checks passed
@Huijiro Huijiro deleted the grodrigues/agent-558-templates branch September 5, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants