Skip to content

Conversation

@Huijiro
Copy link
Member

@Huijiro Huijiro commented Sep 9, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Updated the Vercel Groq template to use npm for dependency installation, improving compatibility on environments without Bun.
    • Suppressed funding and audit prompts during install for a smoother, non-interactive setup.
  • Chores

    • Standardized the installation flow in the template by replacing Bun-specific commands with npm equivalents.
    • Preserved the set of installed packages; no changes to dependencies beyond the installation method.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 9, 2025

Walkthrough

The Vercel Groq template in nodejs/templates.yaml was updated to use npm for dependency installation instead of bun, adjusting command flags accordingly. Package targets remain the same.

Changes

Cohort / File(s) Summary
Template install command update
nodejs/templates.yaml
Replaced bun add --silent ai @ai-sdk/groq with npm install --no-fund --no-audit ai @ai-sdk/groq; no other template changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Add groq template #20 — Earlier change introducing bun add --silent ai @ai-sdk/groq to the same Vercel Groq template; this PR reverses the installer to npm with different flags.

Pre-merge checks (1 passed, 1 warning, 1 inconclusive)

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description Check ⚠️ Warning No pull request description was provided, so there is no content that relates to or explains the changes in the PR. Add a brief description summarizing why the Bun commands were replaced with npm in the Vercel Groq template and any context or motivation for the change.
Title Check ❓ Inconclusive The title “Fixes templating issues with groq” does reference the fact that the PR addresses Groq template problems, but it is somewhat generic and does not clearly convey the specific change of replacing the Bun installer commands with an npm-based flow. Consider making the title more specific by mentioning the switch from Bun to npm in the Groq template (for example, “Switch Groq template installer from Bun to npm”).
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Poem

A bunny taps the keys with flair,
From bun to npm—install with care.
Flags aligned, the script runs true,
Packages hop in, tidy and new.
Thump-thump, ship it—groq and ai too! 🐇✨

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch groq-fix

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
nodejs/templates.yaml (1)

80-86: Optional: lock exact versions to reduce drift.

Consider adding --save-exact so generated projects pin exact versions. If you adopt this, mirror it across the other npm-based templates for consistency.

       - install
       - --no-fund
       - --no-audit
+      - --save-exact
       - ai
       - "@ai-sdk/groq"
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f48a3a6 and 4ff1436.

📒 Files selected for processing (1)
  • nodejs/templates.yaml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.yaml

📄 CodeRabbit inference engine (AGENT.md)

All YAML files must start with a schema reference comment: # yaml-language-server: $schema=...

Files:

  • nodejs/templates.yaml
{bunjs,nodejs,python-uv}/templates.yaml

📄 CodeRabbit inference engine (AGENT.md)

Store templates per runtime at {runtime}/templates.yaml

Files:

  • nodejs/templates.yaml
{bunjs,nodejs,python-uv}/**/*

📄 CodeRabbit inference engine (AGENT.md)

Keep runtime-specific template definitions within bunjs/, nodejs/, and python-uv/ directories

Files:

  • nodejs/templates.yaml
🔇 Additional comments (2)
nodejs/templates.yaml (2)

80-86: Groq template: npm migration looks correct and consistent.

Switching to npm with --no-fund/--no-audit matches the other Vercel AI SDK templates (OpenAI/Anthropic/Google). File also complies with the YAML schema header/location guideline.


80-86: Groq template verification passed

The Groq provider block in nodejs/templates.yaml correctly uses npm (no bun commands) and the file common/js/vercel/groq.ts is present.

@Huijiro Huijiro merged commit 79eed3f into main Sep 9, 2025
4 checks passed
@Huijiro Huijiro deleted the groq-fix branch September 9, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants