-
Notifications
You must be signed in to change notification settings - Fork 1
Fixes templating issues with groq #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Vercel Groq template in nodejs/templates.yaml was updated to use npm for dependency installation instead of bun, adjusting command flags accordingly. Package targets remain the same. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Pre-merge checks (1 passed, 1 warning, 1 inconclusive)❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing Touches🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
nodejs/templates.yaml (1)
80-86: Optional: lock exact versions to reduce drift.Consider adding --save-exact so generated projects pin exact versions. If you adopt this, mirror it across the other npm-based templates for consistency.
- install - --no-fund - --no-audit + - --save-exact - ai - "@ai-sdk/groq"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
nodejs/templates.yaml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.yaml
📄 CodeRabbit inference engine (AGENT.md)
All YAML files must start with a schema reference comment:
# yaml-language-server: $schema=...
Files:
nodejs/templates.yaml
{bunjs,nodejs,python-uv}/templates.yaml
📄 CodeRabbit inference engine (AGENT.md)
Store templates per runtime at {runtime}/templates.yaml
Files:
nodejs/templates.yaml
{bunjs,nodejs,python-uv}/**/*
📄 CodeRabbit inference engine (AGENT.md)
Keep runtime-specific template definitions within bunjs/, nodejs/, and python-uv/ directories
Files:
nodejs/templates.yaml
🔇 Additional comments (2)
nodejs/templates.yaml (2)
80-86: Groq template: npm migration looks correct and consistent.Switching to npm with --no-fund/--no-audit matches the other Vercel AI SDK templates (OpenAI/Anthropic/Google). File also complies with the YAML schema header/location guideline.
80-86: Groq template verification passedThe Groq provider block in nodejs/templates.yaml correctly uses npm (no
buncommands) and the filecommon/js/vercel/groq.tsis present.
Summary by CodeRabbit
Bug Fixes
Chores