Sapling ci reenable #21
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: fix missing anyhow reference in the generated Cargo.toml Differential Revision: D87984172
Summary: CentOS Stream 9 default is python 3.9, update the manifest to use the available [redhat 3.12 packages](https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/9/html/installing_and_using_dynamic_programming_languages/assembly_installing-and-using-python_installing-and-using-dynamic-programming-languages) Sapling needs python 3.10+ as it has modern type declarations and match keyword usage. I would have taken the RPMS to 3.10 to match ubuntu 22.04 but we don't have that available so take it to 3.12 to match upcoming CentOS Stream 10. Test fixes: * test-fbconduit.t updated `eden/scm/sapling/httpclient/__init__.py` as it was using a removed deprecated API. The [new one](https://docs.python.org/3.10/library/ssl.html?highlight=sslcontext%20wrap_socket#ssl.SSLContext.wrap_socket) has been present since python 3.7. * test-debugfilterid.t failing as code under test was returning nothing in a non-fb build. It can builds ok in non-fb, so removed the conditional compilation Differential Revision: D88010541
Summary: enable CI now that the build and tests are fixed. Enabling for linux only to limit noise for the teams Differential Revision: D88010549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.