Fixed warnings #23
Open
Fixed warnings #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open4-1.3.0/lib/open4.rb:182: warning: shadowing outer local variable - a open4-1.3.0/lib/open4.rb:213: warning: shadowing outer local variable - a open4-1.3.0/lib/open4.rb:228: warning: shadowing outer local variable - key open4-1.3.0/lib/open4.rb:225: warning: assigned but unused variable - ignored open4-1.3.0/lib/open4.rb:258: warning: shadowing outer local variable - t open4-1.3.0/lib/open4.rb:262: warning: shadowing outer local variable - t open4-1.3.0/lib/open4.rb:268: warning: shadowing outer local variable - buf open4-1.3.0/lib/open4.rb:340: warning: shadowing outer local variable - i open4-1.3.0/lib/open4.rb:340: warning: shadowing outer local variable - stdin open4-1.3.0/lib/open4.rb:345: warning: shadowing outer local variable - o open4-1.3.0/lib/open4.rb:345: warning: shadowing outer local variable - stdout open4-1.3.0/lib/open4.rb:349: warning: shadowing outer local variable - o open4-1.3.0/lib/open4.rb:349: warning: shadowing outer local variable - stderr open4-1.3.0/lib/open4.rb:384: warning: shadowing outer local variable - arg open4-1.3.0/lib/open4.rb:384: warning: shadowing outer local variable - argv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use ruby-2.0.0 with -w option when running tests and I got many warnings that annoyed me a little. I fixed these warnings, here is the patch.
open4-1.3.0/lib/open4.rb:182: warning: shadowing outer local variable - a
open4-1.3.0/lib/open4.rb:213: warning: shadowing outer local variable - a
open4-1.3.0/lib/open4.rb:228: warning: shadowing outer local variable - key
open4-1.3.0/lib/open4.rb:225: warning: assigned but unused variable - ignored
open4-1.3.0/lib/open4.rb:258: warning: shadowing outer local variable - t
open4-1.3.0/lib/open4.rb:262: warning: shadowing outer local variable - t
open4-1.3.0/lib/open4.rb:268: warning: shadowing outer local variable - buf
open4-1.3.0/lib/open4.rb:340: warning: shadowing outer local variable - i
open4-1.3.0/lib/open4.rb:340: warning: shadowing outer local variable - stdin
open4-1.3.0/lib/open4.rb:345: warning: shadowing outer local variable - o
open4-1.3.0/lib/open4.rb:345: warning: shadowing outer local variable - stdout
open4-1.3.0/lib/open4.rb:349: warning: shadowing outer local variable - o
open4-1.3.0/lib/open4.rb:349: warning: shadowing outer local variable - stderr
open4-1.3.0/lib/open4.rb:384: warning: shadowing outer local variable - arg
open4-1.3.0/lib/open4.rb:384: warning: shadowing outer local variable - argv