feat: add extension descriptions #225
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SprGrf
previously approved these changes
Jan 22, 2026
yrh012
previously approved these changes
Jan 22, 2026
eeberhard
reviewed
Jan 27, 2026
source/modulo_components/extension_descriptions/modulo_component.yaml
Outdated
Show resolved
Hide resolved
.../modulo_controllers/extension_descriptions/modulo_controllers_base_controller_interface.yaml
Show resolved
Hide resolved
Member
Author
|
Thanks for the good review, I missed the validation a couple months back |
yrh012
reviewed
Jan 27, 2026
...modulo_controllers/extension_descriptions/modulo_controllers_robot_controller_interface.yaml
Outdated
Show resolved
Hide resolved
yrh012
reviewed
Jan 28, 2026
| default_value: 1.0 | ||
| validation: | ||
| range: | ||
| exclusive_minimum: 0 |
There was a problem hiding this comment.
Suggested change
| exclusive_minimum: 0 | |
| minimum: 0 |
Member
Author
There was a problem hiding this comment.
I added a FIXME comment, I think this shouldn't be allowed to be set to zero. Same for predicate_publishing_rate
yrh012
reviewed
Jan 28, 2026
.../modulo_controllers/extension_descriptions/modulo_controllers_base_controller_interface.yaml
Show resolved
Hide resolved
yrh012
reviewed
Jan 28, 2026
| internal: true | ||
| validation: | ||
| range: | ||
| exclusive_minimum: 0 |
There was a problem hiding this comment.
This doesn't have a check in modulo on a certain minimum, https://github.com/aica-technology/modulo/blob/main/source/modulo_controllers/src/ControllerInterface.cpp
yrh012
previously approved these changes
Jan 28, 2026
yrh012
left a comment
yrh012
left a comment
There was a problem hiding this comment.
Besides the above comments, should be good for me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently found those changes locally, why not add them.
Review guidelines
Estimated Time of Review: 5 minutes
Checklist before merging: