Skip to content
This repository was archived by the owner on Jan 17, 2024. It is now read-only.

Conversation

@realsnake
Copy link

No description provided.

@realsnake
Copy link
Author

Hi,

I test my commit in Simplified Chinese and English, it works. Other language I've not tested. But I do find a issue with this commit, maybe it also exist in the original version.

if I use blow UIAlert code:

    UIAlertView *alert = [[UIAlertView alloc] initWithTitle:NSLocalizedString(@"警告", @"警告") message:nil delegate:self cancelButtonTitle:NSLocalizedString(@"确定", @"确定") otherButtonTitles:nil];

It can't grep out NSLocalizedString from within a line, it generate unwanted result.
So, I need to change it to:

    NSString *title = NSLocalizedString(@"警告", @"警告");
    NSString *ok = NSLocalizedString(@"确定", @"确定");
    UIAlertView *alert = [[UIAlertView alloc] initWithTitle:title message:nil delegate:self cancelButtonTitle:ok otherButtonTitles:nil];

I'm not familiar with regular expression. I've learnt serval hours on the net and try to make this commit. I think you'd better do some more test. Anyway, thanks for your wonderful tutorial, it's really helpful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants