-
Notifications
You must be signed in to change notification settings - Fork 77
fix: upgrade next-navigation-guard to 0.2.0 for Android 10 compatibility #2427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Comment |
apps/deploy-web/src/hooks/useNavigationGuard/NavigationGuardProvider.spec.tsx
Outdated
Show resolved
Hide resolved
974460c to
a0787d7
Compare
| }, | ||
| "apps/api/node_modules/@opentelemetry/core": { | ||
| "version": "2.0.0", | ||
| "resolved": "https://registry.npmjs.org/@opentelemetry/core/-/core-2.0.0.tgz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔄 Carefully review the package-lock.json diff
Resolve the comment if everything is ok
* node_modules/next-navigation-guard 0.1.2 -> 0.2.0
+ node_modules/git-semver-tags/node_modules/conventional-commits-filter 5.0.0
+ node_modules/git-semver-tags/node_modules/conventional-commits-parser 6.2.1
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2427 +/- ##
=======================================
Coverage 51.25% 51.25%
=======================================
Files 1072 1072
Lines 29393 29393
Branches 6472 6504 +32
=======================================
Hits 15065 15065
Misses 13998 13998
Partials 330 330
🚀 New features to boost your workflow:
|
Co-authored-by: stalniy <1159966+stalniy@users.noreply.github.com>
…solidate tests Co-authored-by: stalniy <1159966+stalniy@users.noreply.github.com>
Co-authored-by: stalniy <1159966+stalniy@users.noreply.github.com>
a0787d7 to
88d4eab
Compare
Version 0.1.2 crashes on Android 10 with
TypeError: crypto.randomUUID is not a functionbecausecrypto.randomUUID()is unavailable in older browsers.Changes
next-navigation-guardfrom^0.1.2to^0.2.0Math.random().toString(36).substring(2)instead ofcrypto.randomUUID()for broader compatibilityImplementation Detail
The library now generates tokens using:
No API changes required in consuming code - existing usage of
NavigationGuardProvideranduseNavigationGuardremains unchanged. The existing test suite inuseNavigationGuard.spec.tsalready provides comprehensive coverage of the navigation guard functionality.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.