Skip to content

Conversation

@troian
Copy link
Member

@troian troian commented Nov 23, 2025

fixes akash-network/support#396

Signed-off-by: Artur Troian <troian@users.noreply.github.com>
@troian troian requested a review from a team as a code owner November 23, 2025 01:25
@coderabbitai
Copy link

coderabbitai bot commented Nov 23, 2025

Walkthrough

Updated Go runtime version from 1.25.2 to 1.25.4 in go.mod. This addresses a certificate parsing regression in the Go standard library that caused akash export to panic with malformed x509 SAN dNSName errors.

Changes

Cohort / File(s) Summary
Go Version Bump
go.mod
Updated Go version constraint from 1.25.2 to 1.25.4 to resolve x509 certificate parsing regression

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A version bump, so small and neat,
From 1.25.2 to 1.25.4—what a treat!
The cert bug that made our export fail,
Is fixed in the Go update without fail.
Now akash export runs with glee,
Happy as a rabbit, wild and free! 🌟

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: bumping Go version to 1.25.4 as shown in go.mod.
Description check ✅ Passed The description references the linked issue (#396) that documents the need for this Go version upgrade to fix an x509 SAN dNSName panic.
Linked Issues check ✅ Passed The PR directly addresses the requirement in issue #396 by upgrading Go from 1.25.2 to 1.25.4, which contains the Cert regression fix (golang/go#75828) needed to resolve the akash export failure.
Out of Scope Changes check ✅ Passed The PR contains only the necessary Go version bump in go.mod with no extraneous changes, staying fully aligned with the objective to fix the export panic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch deps

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9e1d6cf and 6354e62.

📒 Files selected for processing (1)
  • go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (16)
  • GitHub Check: network-upgrade
  • GitHub Check: coverage
  • GitHub Check: release-dry-run
  • GitHub Check: sims
  • GitHub Check: lint-shell
  • GitHub Check: lint-go
  • GitHub Check: build-macos
  • GitHub Check: build-bins
  • GitHub Check: tests
  • GitHub Check: release-dry-run
  • GitHub Check: sims
  • GitHub Check: lint-go
  • GitHub Check: tests
  • GitHub Check: coverage
  • GitHub Check: build-macos
  • GitHub Check: build-bins
🔇 Additional comments (1)
go.mod (1)

3-3: Go version bump appropriately addresses the certificate regression and requires no other synchronization.

The upgrade from go 1.25.2 to go 1.25.4 directly fixes the x509 SAN dNSName malformed panic (golang/go#75828). Verification confirms:

  • go1.25.4 is a valid released version
  • CI workflows dynamically detect the Go version from go.mod using ./script/tools.sh gotoolchain, so no manual workflow updates are needed
  • No other version declarations in Dockerfiles or configuration files require synchronization

This patch-level bump is backward-compatible and carries minimal risk.


Comment @coderabbitai help to get the list of available commands and usage tips.

@troian troian merged commit 41aa2fe into main Nov 23, 2025
33 of 34 checks passed
@troian troian deleted the deps branch November 23, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

akash export fails on v1.0.x

2 participants