-
Notifications
You must be signed in to change notification settings - Fork 258
ci: update cache before install #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated GitHub Actions CI: the Ubuntu setup action now runs Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/actions/setup-ubuntu/action.yaml (1)
17-19: LGTM! This correctly fixes the CI failure.The addition of
apt-get updateensures the package cache is refreshed before installation, which resolves the issue with the removed libudev-dev version. The switch fromapttoapt-getis also a good practice for scripting, asapt-getprovides a more stable interface for automated environments.Optional: Consider adding error handling for network resilience
For improved robustness against transient network issues, you could add retry logic or explicit error handling:
run: | - sudo apt-get update - sudo apt-get install -y make direnv unzip lz4 wget curl npm jq pv coreutils libudev-dev + sudo apt-get update || { echo "apt-get update failed, retrying..."; sleep 5; sudo apt-get update; } + sudo apt-get install -y make direnv unzip lz4 wget curl npm jq pv coreutils libudev-devOr for stricter error handling:
run: | + set -e sudo apt-get update sudo apt-get install -y make direnv unzip lz4 wget curl npm jq pv coreutils libudev-dev
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/actions/setup-ubuntu/action.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: network-upgrade
- GitHub Check: release-dry-run
- GitHub Check: lint-go
- GitHub Check: sims
- GitHub Check: build-bins
- GitHub Check: tests
- GitHub Check: build-macos
- GitHub Check: coverage
.github/workflows/tests.yaml
Outdated
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| - name: Free disk space |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After I fixed version issue I started to hit out of space error.
Decided to cleanup github action runner deps that are not used in our case.
|
Moved the solution to akash-network/support#406 |
Description
Ubuntu's package repository updated and removed the old package version libudev-dev_255.4-1ubuntu8.11. The CI system is trying to fetch a specific old version that no longer exists in the repository.
Changes
apt installwithapt-get installwhich is more suitable for scriptsAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.md