Introduce new carrier format based on pydantic models. #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paradoxxxzero
force-pushed
the
pydantic
branch
7 times, most recently
from
8fde3e3 to
6898c25
Compare
paradoxxxzero
force-pushed
the
pydantic
branch
5 times, most recently
from
9529a4a to
7879c3b
Compare
Implement mondialrelay get_label as an example.
florian-dacosta
approved these changes
Apr 22, 2025
Member
florian-dacosta
left a comment
florian-dacosta
left a comment
There was a problem hiding this comment.
Code review (mainly for the not mondial relay part) + tests with the DPD implementation.
I also have tested geodis and dpd with old implementation with this branch and did not spot any regression.
It seems promising to me and I like the new way to do it.
I think we could merge it quickly as it does not impact the old stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement mondialrelay
get_label,search_pickup_sitesandget_pickup_siteas an example.