[FIX] gha testrunner - Close #70 #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the continuous integration GitHub Action to work correctly with pull requests from forked repositories. The solution implements a two-workflow pattern where test execution and report generation are separated to avoid permission issues with read-only tokens in forked PR contexts.
Changes:
- Separated test execution from report generation by creating two distinct workflows
- Modified the test runner workflow to upload test results as artifacts instead of directly creating check runs
- Created a new test reporter workflow that runs in the context of the main repository with appropriate write permissions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/bitblazor-testrunner.yml | Removed check write permissions and replaced direct test reporting with artifact upload for test results |
| .github/workflows/bitblazor-testreporter.yml | New workflow that downloads test artifacts and creates test reports with proper permissions in the main repository context |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…eporter.yml, step name and retention days for upload step in bitblazor-testrunner.yml)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated workflows for testing and building the test report.
Close #70