Subtype config used as key defaultval #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest version of Java 1.8.0_191 enforces that Manifest classpath entries be relative. https://issues.apache.org/jira/browse/SUREFIRE-1588
When deleting files during teardown, if a temporary file can't be deleted then the test should not fail for that reason. Log that the file could not be delete and carry on.
When deleting files during teardown, if a temporary file can't be deleted then the test should not fail for that reason. Log that the file could not be delete and carry on.
* origin/pr/1013: [core] Remove unused Logger in OsgiTestBase [core] Disable BashCommandsIntegrationTest test on Windows [test-support] Add @DisableOnWindows annotation for TestNG tests [core] Fix syntax for maven-compiler plugin [utils] Extract FileUtil.deleteDirectory() from duplicated code [core] embedded framework test survives teardown [rt-felix] embedded framework test survives teardown
prevents delays while it tries to resolve things which aren't immediately available
…hich don't set template tag
* origin/pr/1015: introduce new distinct "application" itemType on catalog BOM files, which don't set template tag when getting details, get the raw value then resolve it immediately
this includes that in the payload if different
this adds a block to config yaml tests that fail both here and in master, in a similar way to some of the other failures introduced here the next PR fixes it
when we override we change e.g. the default value or the description, but we don't intend to change how it extracts. without this if we overwrite a StructuredConfigKey we lose its smarts for extracting. also when we coerce on write we didn't treat overwritten StructuredConfigKeys the same as StructuredConfigKeys. also we had overlooked the case where a List containing a Future is being passed to a ConfigKey<Set>. this repairs all those cases.
this now excludes: <constraint>ALWAYS_TRUE</constraint> and <deprecatedNames>(messy expression for empty immutable list)</deprecated> but it _will_ read them in just find so persisted state reading is unchanged, writing is less verbose
the failure was a simple default value has changed as expected by this PR, but there are some other cases that it's interesting to check
Author
|
All tests pass for me locally, in a principled way. As described at apache#1014 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes some of the tests in obvious ways, changes how overwritten keys are evaluated and some of the coercion logic. also changes serialization of config keys not to write very common default values. more detail in individual commits.
merges master, so ignore all the commits before 24 Nov