Updated Logogistiks PR #2
Conversation
I added a section for various camera styles like angles, framing, shot focus and shot size
Reviewer's Guide by SourceryThis pull request enhances the existing HTML document by adding a new 'Camera' section. This section provides an in-depth guide on various camera techniques, including shot sizes, framing, focus, and angles. The changes include new menu navigation, detailed descriptions, and illustrative images to help users understand different camera techniques. Additionally, external references are provided for further reading. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @aleph23 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider breaking this large PR into smaller, more focused changes. This would make it easier to review and manage.
- The HTML structure is quite repetitive. Consider using templates or a more modular approach to reduce duplication and improve maintainability.
- Ensure that all referenced images are present in the repository or will be added in a separate PR. Also, consider adding appropriate CSS and JavaScript to enhance the presentation and interaction of this new content.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| <h4>Medium Wide Shot (MWS)</h4> | ||
| <p>A medium long shot (aka medium long shot) frames the subject from roughly the knees up. It splits the | ||
| difference | ||
| between a full shot and a medium shot. Here's an example of the medium wide shot size from the movie The | ||
| Usual Suspects: | ||
| </p> | ||
| <img width="1600" src="img/camera/shot_size/MWS.webp"> | ||
| <p>You can always frame camera shots from any angle as well, so don't be afraid to think about medium long shots |
There was a problem hiding this comment.
issue: Inconsistent terminology for Medium Wide Shot.
The term 'Medium Wide Shot' is abbreviated as 'MWS' but is also referred to as 'medium long shot' in the description. Consider standardizing the terminology to avoid confusion.
| <p>The medium close-up camera shot size keeps the characters eerily distant even during their face-to-face | ||
| conversation. | ||
| </p> | ||
| <h4>Close Up (CU)</h4> |
There was a problem hiding this comment.
issue: Duplicate content in Close Up section.
The description for the Close Up shot is repeated twice. Consider removing the duplicate content to improve readability.
| cityscapes. | ||
| </p> | ||
| <img width="1600" src="img/camera/angles/Aerial_Shot.webp"> | ||
| <h3>All Content is taken from this article: <a href="https://www.studiobinder.com/blog/ultimate-guide-to-camera-shots/" target="_blank">Ultimate guide to camera shots</a></h3> |
There was a problem hiding this comment.
suggestion: Consider rephrasing the attribution statement.
The attribution statement 'All Content is taken from this article' could be rephrased to 'All content is sourced from this article' for better readability.
| <h3>All Content is taken from this article: <a href="https://www.studiobinder.com/blog/ultimate-guide-to-camera-shots/" target="_blank">Ultimate guide to camera shots</a></h3> | |
| <h3>All content is sourced from this article: <a href="https://www.studiobinder.com/blog/ultimate-guide-to-camera-shots/" target="_blank">Ultimate guide to camera shots</a></h3> |
2 participants
May already be in my fork - diff PR to confirm.
Summary by Sourcery
This pull request introduces a comprehensive 'Camera' section to the index.html, enhancing the document with detailed explanations and examples of different camera shot sizes, framing techniques, focus methods, and angles.