Skip to content

Include Rendering in Base and Api instead of SuperBase #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tnandate wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include Rendering in Base and Api instead of SuperBase #6

tnandate wants to merge 1 commit into from

Conversation

@tnandate
Copy link

@tnandate tnandate commented Jul 25, 2020 •
edited
Loading

Hi, thanks for the great example.

AwesomeController::Rendering is included in AwesomeController::SuperBase and AwesomeController::Base.
In actual Rails, AbstractController::Rendering is not included in ActionController::Metal, but is included in ActionController::API and ActionController::Base, which inherit from ActionController::Metal.

So I think it's better to align with the actual behavior of Rails.

  • I've confirmed that all the tests pass.

@tnandate
Include AwesomeController::Rendering in AwesomeController::Base and A…
1784ec0 
…wesomeController::Api instead of AwesomeController::SuperBase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tnandate