Gamedata for TF2 Classified #2398
Conversation
Kenzzer
left a comment
Kenzzer
left a comment
There was a problem hiding this comment.
Whether this gets merged or not is psychonic's decision. But the PR looks good, and I've one (non-blocking) suggestion.
| /* CBaseAnimating::LookupAttachment */ | ||
| /* String: "vehicle_driver_eyes", middle length top function, with 4 calls, pick the first one. */ | ||
| "library" "server" | ||
| //"windows64" "\x48\x89\x5C\x24\x08\x57\x48\x83\xEC\x20\x80\xB9\x65\x04\x00\x00\x00\x48\x8B\xFA\x48\x8B\xD9\x75\x2A\x48\x83\xB9\xC0\x05\x00\x00\x00\x75\x2A\xE8\x2A\x2A\x2A\x2A\x48\x85\xC0\x74\x2A\x48\x8B\xCB\xE8\x2A\x2A\x2A\x2A\x48\x8B\x8B\xC0\x05\x00\x00\x48\x85\xC9\x74\x2A\x48\x83\x39\x00\x74\x2A\x48\x8B\xD7\xE8\x2A\x2A\x2A\x2A" |
There was a problem hiding this comment.
Any reason this signature is commented out ? As a suggestion, if you wish to give 'prime' support towards sourcemod/other server mods, may I suggest tagging this function and others if any with
__declspec( dllexport ) ?
If modifying the main codebase is too troublesome, then some extra source file akin to
class __declspec( dllexport ) CExposeToServerMods {
public:
int LookupAttachment( const char *szName ) {
return ((CBaseAnimating*)this)->LookupAttachment( szName );
}
};servermodexpose.cpp
With either solution, you can then fill windows gamedata with
"windows64" "@?LookupAttachment@CBaseAnimating@@QAEHPBD@Z"
or
"windows64" "@?LookupAttachment@CExposeToServerMods@@QAEHPBD@Z"
The added bonus is that you won't have to fetch windows signatures everytime you've updated tf2classified.
There was a problem hiding this comment.
With either solution, you can then fill windows gamedata with
"windows64" "@?LookupAttachment@CBaseAnimating@@QAEHPBD@Z"or"windows64" "@?LookupAttachment@CExposeToServerMods@@QAEHPBD@Z"The added bonus is that you won't have to fetch windows signatures everytime you've updated tf2classified.
I'm learning new thingy
I'm always okay with community-maintained gamedata entering the tree (although we can look at other patterns for that if the workflow becomes cumbersome) Whether or not your suggestion is implemented, we can always merge now and then optionally make an addition/change later. I'm good with it either way |
i went ahead and exported functions people may need as suggested; this is a bit urgent so i'm okay with merging for now, i'll make a followup pr later |
4 participants
This PR contains gamedata for the upcoming release of TF2 Classified