Unpin dependencies in requirements.in
#4657
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to freeze our requirements with a custom script. This script needed version numbers in the `.in` file (then called `requirements-app.txt`) so it could check that the `requirements.txt` file was up to date. Here’s where it was doing that: https://github.com/alphagov/notifications-api/pull/1938/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R107-R112 Since then we’ve moved to `pip-compile` and the `uv pip-compile` to do the same thing. These are much better at not modifying the `requirements.txt` file unless they have to. We also moved to checking that the requirements files is correct by re-generating it, rather than comparing it: https://github.com/alphagov/notifications-aws/pull/1207/files Doing this will make it easier for us (and Dependabot) to bump the versions of things because we’ll only need to do so in one place.
It’s a sub-dependency of `gds-metrics` so we don’t need to declare it explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to freeze our requirements with a custom script. This script needed version numbers in the
.infile (then calledrequirements-app.txt) so it could check that therequirements.txtfile was up to date.Here’s where it was doing that:
https://github.com/alphagov/notifications-api/pull/1938/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R107-R112
Since then we’ve moved to
pip-compileand thenuv pip-compileto do the same thing.These are much better at not modifying the
requirements.txtfile unless they have to.We also moved to checking that the requirements files is correct by re-generating it, rather than comparing it:
https://github.com/alphagov/notifications-aws/pull/1207
Doing this will make it easier for us (and Dependabot) to bump the versions of things because we’ll only need to do so in one place.