Alsaloop fix short options #317
Open
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage info documents both short and long form arguments for these: "-B,--buffer buffer size in frames\n" "-E,--period period size in frames\n" But the short form was missing from the optstring so it wasn't accepted: alsaloop -B 123 -E 42 alsaloop: invalid option -- 'B' alsaloop: invalid option -- 'E' Fix that. Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
It is not documented in the usage info, no corresponding long option and is not handled in the parsing, so drop it from the optstring. Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
The usage info documents a long form --wake option: "-W,--wake process wake timeout in ms\n" But it wasn't handled: alsaloop --wake 42 alsaloop: unrecognized option '--wake' Fix that. Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
The 'd' and 'm' options were not in the same order as the long options. Fix that. No functional change, but makes it easier to ensure they are kept in sync. Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various minor fixes to the alsaloop command line parsing