Skip to content

Conversation

@alstjs1207
Copy link
Owner

@alstjs1207 alstjs1207 commented Dec 17, 2021

PR 의 종류는 어떤 것인가요?

  • 버그 수정
  • 새로운 기능
  • 리팩토링

수정이 필요하게된 이유가 무엇인가요? (Jira 이슈가 있다면 링크를 연결해주세요)

무엇을 어떻게 변경했나요?

kotlin 의 lint, prettier 설정

코드 변경을 이해하기 위한 배경지식이 필요하다면 설명 해주세요.

디펜던시 변경이 있나요?

ktlint 10.2.0

어떻게 테스트 하셨나요?

코드의 실행결과를 볼 수 있는 로그가 있다면 첨부해주세요.

@alstjs1207 alstjs1207 self-assigned this Dec 17, 2021
@github-actions
Copy link

github-actions bot commented Dec 17, 2021

Unit Test Results

5 files  5 suites   0s ⏱️
7 tests 7 ✔️ 0 💤 0

Results for commit 57ec231.

♻️ This comment has been updated with latest results.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/MutableVisitor.kt|1 col 1| File must end with a newline (\n)
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/MutableVisitor.kt|5 col 16| Missing spacing before ":"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/MutableVisitor.kt|6 col 16| Missing spacing before ":"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/MutableVisitor.kt|8 col 16| Missing spacing before ":"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/MutableVisitor.kt|273 col 48| Unexpected spacing before "("
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/MutableVisitor.kt|325 col 28| Missing spacing before ":"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/MutableVisitor.kt|327 col 28| Missing spacing before ":"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/MutableVisitor.kt|343 col 15| Missing spacing before ":"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/MutableVisitor.kt|347 col 15| Missing spacing before ":"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Node.kt|1 col 1| File must end with a newline (\n)
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/ObjectSerializer.kt|1 col 1| File must end with a newline (\n)
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/ObjectSerializer.kt|43 col 1| Unexpected blank line(s) before "}"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Parser.kt|31 col 87| Missing newline after "("
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Parser.kt|35 col 5| Missing newline before ")"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Visitor.kt|1 col 1| File must end with a newline (\n)
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Visitor.kt|292 col 38| Unnecessary space(s)
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Visitor.kt|317 col 28| Missing spacing before ":"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Visitor.kt|319 col 28| Missing spacing before ":"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|3 col 1| Needless blank line(s)
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|78 col 28| Missing newline after "("
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|84 col 21| Missing newline before ")"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|112 col 26| Missing newline after "("
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|113 col 64| Missing newline before ")"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|113 col 109| Missing newline before ")"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|316 col 41| Missing newline after "("
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|322 col 21| Missing newline before ")"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|456 col 21| Missing newline after "("
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|458 col 9| Missing newline before ")"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|464 col 21| Missing newline after "("
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|466 col 9| Missing newline before ")"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|532 col 38| Missing newline after "("
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|533 col 1| Unexpected indentation (28) (should be 24)
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|533 col 84| Missing newline before ")"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|533 col 85| Missing newline before ")"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|544 col 84| Line must not end with "?."
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|547 col 18| Missing newline after "("
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|547 col 48| Missing newline after "("
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|548 col 90| Missing newline before ")"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|548 col 91| Missing newline before ")"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|548 col 92| Missing newline before ")"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|592 col 58| Missing newline before ")"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|593 col 41| Missing newline after "("
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|594 col 85| Missing newline before ")"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|594 col 86| Missing newline before ")"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|631 col 1| Unexpected indentation (8) (should be 12)
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|632 col 1| Unexpected indentation (8) (should be 12)
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|633 col 1| Unexpected indentation (8) (should be 12)
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/Writer.kt|644 col 15| Missing spacing before ":"
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/main.kt|9 col 1| Unused import
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/main.kt|12 col 1| Unused import
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/main.kt|14 col 1| Unused import
node_modules/prettier-plugin-kotlin/kotato/src/main/kotlin/com/github/angrypotato/kotato/main.kt|17 col 1| Needless blank line(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants