feat: add Mermaid diagrams and enhanced validation #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 5 Mermaid diagrams replacing ASCII art: - Layered Architecture (docs/architecture.md) - Data Flow sequence diagram (docs/architecture.md) - Test Pyramid (docs/architecture.md) - Getting Started Flow (docs/quickstart.md) - CBA Workflow (codebase-agent.md) Also: - Fix malformed code block endings in architecture.md - Enhance validate-mermaid.sh to extract and validate inline diagrams from markdown files (not just standalone .mmd)
Replace ((var++)) with var=$((var + 1)) to avoid exit code 1 when incrementing from 0 with set -e enabled.
Add puppeteer-config.json with --no-sandbox for GitHub Actions. Update validate-mermaid.sh to use config when available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
validate-mermaid.shto extract and validate inline diagrams from markdown filesdocs/architecture.mdDiagrams Added
docs/architecture.mddocs/architecture.mddocs/architecture.mddocs/quickstart.md.claude/agents/codebase-agent.mdValidation Enhancement
The updated
validate-mermaid.shnow:mmdc(mermaid-cli)Test Plan
./scripts/validate-mermaid.sh