Skip to content

fix(session-replay-browser): prevent broken styles while recording with more CSS-in-JS libraries #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sullvn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(session-replay-browser): prevent broken styles while recording with more CSS-in-JS libraries #1499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/session-replay-browser/src/session-replay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,8 +633,10 @@ export class SessionReplay implements AmplitudeSessionReplay {
errorHandler: (error: unknown) => {
const typedError = error as Error & { _external_?: boolean };

// styled-components relies on this error being thrown and bubbled up, rrweb is otherwise suppressing it
if (typedError.message.includes('insertRule') && typedError.message.includes('CSSStyleSheet')) {
// CSS-in-JS libraries such as styled-components and stitches rely on this error being thrown and
// bubbled up, rrweb is otherwise suppressing it. The goal is to rethrow errors from
// `CSSStyleSheet.insertRule` and `CSSGroupingRule.insertRule`.
if (typedError.stack?.includes('insertRule')) {
throw typedError;
}

Expand Down