📦 Update dependency chromedriver to v143

[renovate]

This PR contains the following updates:

Package	Change	Age	Confidence
chromedriver	131.0.5 -> 143.0.3

See all other Renovate PRs on the Dependency Dashboard

How to resolve breaking changes

This PR may introduce breaking changes that require manual intervention. In such cases, you will need to check out this branch, fix the cause of the breakage, and commit the fix to ensure a green CI build. To check out and update this PR, follow the steps below:

# Check out the PR branch
git checkout -b renovate/major-chrome-and-chromedriver main
git pull https://github.com/ampproject/amphtml.git renovate/major-chrome-and-chromedriver

# Directly make fixes and commit them
amp lint --fix # For lint errors in JS files
amp prettify --fix # For prettier errors in non-JS files
# Edit source code in case of new compiler warnings / errors

# Push the changes to the branch
git push git@github.com:ampproject/amphtml.git renovate/major-chrome-and-chromedriver:renovate/major-chrome-and-chromedriver

---

Release Notes

giggio/node-chromedriver (chromedriver)

v143.0.3

Compare Source

v143.0.2

Compare Source

v143.0.1

Compare Source

v143.0.0

Compare Source

v142.0.3

Compare Source

v142.0.2

Compare Source

v142.0.1

Compare Source

v142.0.0

Compare Source

v141.0.6

Compare Source

v141.0.5

Compare Source

v141.0.4

Compare Source

v141.0.3

Compare Source

v141.0.2

Compare Source

v141.0.1

Compare Source

v141.0.0

Compare Source

v140.0.4

Compare Source

v140.0.3

Compare Source

v140.0.2

Compare Source

v140.0.1

Compare Source

v140.0.0

Compare Source

v139.0.3

Compare Source

v139.0.2

Compare Source

v139.0.1

Compare Source

v139.0.0

Compare Source

v138.0.5

Compare Source

v138.0.4

Compare Source

v138.0.3

Compare Source

v138.0.2

Compare Source

v138.0.1

Compare Source

v138.0.0

Compare Source

v137.0.4

Compare Source

v137.0.3

Compare Source

v137.0.2

Compare Source

v137.0.1

Compare Source

v137.0.0

Compare Source

v136.0.3

Compare Source

v136.0.2

Compare Source

v136.0.1

Compare Source

v136.0.0

Compare Source

v135.0.4

Compare Source

v135.0.3

Compare Source

v135.0.2

Compare Source

v135.0.1

Compare Source

v135.0.0

Compare Source

v134.0.5

Compare Source

v134.0.4

Compare Source

v134.0.3

Compare Source

v134.0.2

Compare Source

v134.0.1

Compare Source

v134.0.0

Compare Source

v133.0.3

Compare Source

v133.0.2

Compare Source

v133.0.1

Compare Source

v133.0.0

Compare Source

v132.0.2

Compare Source

v132.0.1

Compare Source

v132.0.0

Compare Source

---

Configuration

📅 Schedule: Branch creation - "after 12am every weekday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[danielrozenberg]

@powerivq @erwinmombay

Three tests get broken by this update. Two of them are easy fixes that don't seem to have any major effect, but one of them is a bit sus.

The simple ones are:

1. Changing line 146 in test/unit/core/dom/test-jsx.js:

   it('attributes are safe', () => {
     const element = <div data-dangerous={'"><script src="foo.js'} />;
     expect(element.outerHTML).to.equal(
-      '<div data-dangerous="&quot;><script src=&quot;foo.js"></div>'
+      '<div data-dangerous="&quot;&gt;&lt;script src=&quot;foo.js"></div>'
     );
   });

2. Changing line 369 in test/unit/preact/test-base-element-mapping.js:

     it('should render from scratch', async () => {
       doc.body.appendChild(element);
       await element.buildInternal();
       await waitFor(() => component.callCount > 0, 'component rendered');
       expect(component).to.be.calledOnce;
-      const container = element.shadowRoot.querySelector(':scope c');
+      const container = element.shadowRoot.querySelector('c');
       expect(container).to.be.ok;
       expect(container.style.display).to.equal('contents');
       expect(container.querySelector(':scope #component')).to.be.ok;
       expect(
         element.shadowRoot.querySelectorAll('slot[name="i-amphtml-svc"]')
       ).to.have.lengthOf(1);
     });

But for the one that might be an issue - the fix is to change line 419 in test/unit/test-purifier.js:

     it('should output diff marker attributes for some elements', () => {
       // Elements with bindings should have [i-amphtml-key=<number>].
       expect(purify('<p [x]="y"></p>')).to.match(
         /<p data-amp-bind-x="y" i-amphtml-binding="" i-amphtml-key="(\d+)"><\/p>/
       );
       // AMP elements should have [i-amphtml-key=<number>].
       expect(purify('<amp-pixel></amp-pixel>')).to.match(
         /<amp-pixel i-amphtml-key="(\d+)"><\/amp-pixel>/
       );
       // AMP elements with bindings should have [i-amphtml-key=<number>].
       expect(purify('<amp-pixel [x]="y"></amp-pixel>')).to.match(
-        /<amp-pixel data-amp-bind-x="y" i-amphtml-binding="" i-amphtml-key="(\d+)"><\/amp-pixel>/
+        /<amp-pixel data-amp-bind-x="y" i-amphtml-binding="" \[x\]="y" i-amphtml-key="(\d+)"><\/amp-pixel>/
       );
       // amp-img should have [i-amphtml-ignore].
       expect(purify('<amp-img></amp-img>')).to.equal(
         '<amp-img i-amphtml-ignore=""></amp-img>'
       );
       // Other elements should NOT have [i-amphtml-key].
        expect(purify('<p></p>')).to.equal('<p></p>');
       expect(rewriteAttributeValueSpy.callCount).to.be.equal(2);
     });

It looks like the purifier is behaving differently now, so I'm not sure if this is a "clean" fix. wdyt?