This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Review #26
Open
Review #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Mikhail,
|
Author
|
Alex, thanks for the comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is review 1. I have looked through the all code except YARN (I have to learn it). Basically, there are comments about descriptions of the code in this review. Especially, the executors code needs description (what is curved, flat ...). Also, It will be nice to have a general description of the Skygrid (what is skygrid, libscheduler, metascheduler, executors and so on).
I'II make more reviews, when I'II understand the code in details.
But generally, I like your code)