Skip to content

Conversation

@Houria-hs
Copy link

##Bug Fix: Bottom Panel Cutoff

This PR addresses a layout issue where the camera and score panels (.bottom-panel) were being pushed off the screen on devices with limited vertical resolution, specifically 13-inch and 14-inch laptops (viewports around 800–950px tall).

The issue stemmed from the vertical space not being dynamically allocated, causing the fixed height of the Game Container (.game-container) to push the elements below it past the viewport.

##Solution: Activating Dynamic Layout

The Game Container's explicit height declarations prevented it from working dynamically. This PR removes the conflicting fixed height declarations and activates Flexbox growth to resolve the vertical overflow issue.

Key CSS Changes:

Dynamic Height Activation: Explicit height: 60vh; (and 50vh; in the media query) was commented out/removed.

Flexible Growth: The essential property flex-grow: 1; was added to .game-container to ensure it consumes all available vertical space, keeping the .bottom-panel visible at the bottom of the screen.

Clean-up: Conflicting fixed padding and redundant height declarations within the media query were also removed/commented out.

@Houria-hs
Copy link
Author

I'm open for feedback

@anasM0hammad anasM0hammad linked an issue Dec 21, 2025 that may be closed by this pull request
@anasM0hammad anasM0hammad self-requested a review December 22, 2025 06:10
@anasM0hammad
Copy link
Owner

anasM0hammad commented Dec 22, 2025

I do not see any change with this fix. The bigger screens are also getting sliced bottom boxes. Have you checked the fix on correct screen dimensions ?
Screenshot 2025-12-22 at 11 39 34 AM

Copy link
Owner

@anasM0hammad anasM0hammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix not working

@Houria-hs
Copy link
Author

Houria-hs commented Dec 22, 2025 via email

@anasM0hammad
Copy link
Owner

My bad. I will check it again and see what's the problem. Le lun. 22 déc. 2025 à 07:13, Mohammad Anas @.> a écrit :

@.
* requested changes on this pull request. Fix not working — Reply to this email directly, view it on GitHub <#9 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKFBHEGHYBN2MQXP54OXCUT4C6DY7AVCNFSM6AAAAACPVVIJ6GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMMBSHAYDIMZTGQ . You are receiving this because you authored the thread.Message ID: @.***>

Sure, take your time. Let me know if you need any help. Also try to check the changes locally once
Thanks

@anasM0hammad
Copy link
Owner

@Houria-hs any update on the issue?

@Houria-hs
Copy link
Author

I tested it and checked it in my laptop screen, and it was working fine. Let me know if there's anything else I should update

@anasM0hammad
Copy link
Owner

@Houria-hs , The changes are fine but due to these changes the game screen is getting out of the game container when game starts. Adding a screenshot for your reference. The dino is running out of game container.
Screenshot 2025-12-26 at 11 27 08 AM

@anasM0hammad
Copy link
Owner

@Houria-hs Feel free to pick another issue first so you get the understanding of the code base then you can start on this one later. Let me know if you need any help. Also I will suggest thoroughly test your changes by playing the game yourself.
Also its a live project the v2 is approved and published on google chrome web store and we are moving towards releasing v3 soon. check out the extension here : https://chromewebstore.google.com/detail/g-rex/ncmajcpmafieihifoaglleoeippmeaie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small responsive issue for small screen laptops

2 participants