-
Notifications
You must be signed in to change notification settings - Fork 1
fix(ui): Prevent bottom-panel cutoff on short screens #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I'm open for feedback |
anasM0hammad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix not working
|
My bad. I will check it again and see what's the problem.
Le lun. 22 déc. 2025 à 07:13, Mohammad Anas ***@***.***> a
écrit :
… ***@***.**** requested changes on this pull request.
Fix not working
—
Reply to this email directly, view it on GitHub
<#9 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKFBHEGHYBN2MQXP54OXCUT4C6DY7AVCNFSM6AAAAACPVVIJ6GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMMBSHAYDIMZTGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sure, take your time. Let me know if you need any help. Also try to check the changes locally once |
|
@Houria-hs any update on the issue? |
|
I tested it and checked it in my laptop screen, and it was working fine. Let me know if there's anything else I should update |
|
@Houria-hs , The changes are fine but due to these changes the game screen is getting out of the game container when game starts. Adding a screenshot for your reference. The dino is running out of game container. |
|
@Houria-hs Feel free to pick another issue first so you get the understanding of the code base then you can start on this one later. Let me know if you need any help. Also I will suggest thoroughly test your changes by playing the game yourself. |


##Bug Fix: Bottom Panel Cutoff
This PR addresses a layout issue where the camera and score panels (.bottom-panel) were being pushed off the screen on devices with limited vertical resolution, specifically 13-inch and 14-inch laptops (viewports around 800–950px tall).
The issue stemmed from the vertical space not being dynamically allocated, causing the fixed height of the Game Container (.game-container) to push the elements below it past the viewport.
##Solution: Activating Dynamic Layout
The Game Container's explicit height declarations prevented it from working dynamically. This PR removes the conflicting fixed height declarations and activates Flexbox growth to resolve the vertical overflow issue.
Key CSS Changes:
Dynamic Height Activation: Explicit height: 60vh; (and 50vh; in the media query) was commented out/removed.
Flexible Growth: The essential property flex-grow: 1; was added to .game-container to ensure it consumes all available vertical space, keeping the .bottom-panel visible at the bottom of the screen.
Clean-up: Conflicting fixed padding and redundant height declarations within the media query were also removed/commented out.