Skip to content

Conversation

@romanofranz
Copy link
Contributor

No description provided.

@romanofranz romanofranz requested a review from cka-dev as a code owner November 20, 2025 22:13
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @romanofranz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a critical UI test to ensure the TextNoteCanvasScreen correctly preserves its state. The test simulates user input and then triggers an activity recreation, verifying that the data entered into the title and note fields remains intact. This enhancement improves the robustness of the application by confirming that user data is not lost during common lifecycle events like configuration changes.

Highlights

  • New UI Test for State Preservation: A new UI test, textNoteCanvasScreen_savedState(), has been added to CahierAppTest.kt to specifically verify state preservation in the TextNoteCanvasScreen.
  • Activity Recreation Simulation: The test simulates user interaction by entering text into title and note fields, then recreates the activity to ensure the entered data persists across this lifecycle event.
  • Compose UI Test API Usage: New Compose UI testing imports were added to facilitate interaction with text input fields and assert the presence of text after activity recreation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new UI test to verify that the state of the TextNoteCanvasScreen is preserved after an activity recreation. The test implementation is correct and effectively validates the desired behavior. My review includes a few suggestions to enhance the code quality and test robustness, mainly focusing on removing unused imports, avoiding code duplication, and replacing hardcoded strings with string resources to make the tests more resilient to future changes.

Comment on lines 96 to 100
composeTestRule.waitUntil(timeoutMillis = 5000) {
composeTestRule
.onAllNodesWithContentDescription("Add note")
.fetchSemanticsNodes().size == 1
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This waitUntil block is duplicated in other tests within this file (e.g., homeScreen_displaysAndNavigatesToDrawing and homeScreen_displaysAndNavigatesToText). To improve code reuse and maintainability, consider extracting this logic into a common function or a JUnit @Before method. This would ensure the UI is ready before each test runs, without repeating the same waiting logic.

# Conflicts:
#	app/src/androidTest/java/com/example/cahier/CahierAppTest.kt
Copy link
Contributor

@cka-dev cka-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nit comments

@romanofranz romanofranz merged commit d9887ee into main Nov 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants