-
Notifications
You must be signed in to change notification settings - Fork 38
Added tests to verify state preservation in TextNoteCanvasScreen #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @romanofranz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a critical UI test to ensure the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new UI test to verify that the state of the TextNoteCanvasScreen is preserved after an activity recreation. The test implementation is correct and effectively validates the desired behavior. My review includes a few suggestions to enhance the code quality and test robustness, mainly focusing on removing unused imports, avoiding code duplication, and replacing hardcoded strings with string resources to make the tests more resilient to future changes.
| composeTestRule.waitUntil(timeoutMillis = 5000) { | ||
| composeTestRule | ||
| .onAllNodesWithContentDescription("Add note") | ||
| .fetchSemanticsNodes().size == 1 | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This waitUntil block is duplicated in other tests within this file (e.g., homeScreen_displaysAndNavigatesToDrawing and homeScreen_displaysAndNavigatesToText). To improve code reuse and maintainability, consider extracting this logic into a common function or a JUnit @Before method. This would ensure the UI is ready before each test runs, without repeating the same waiting logic.
# Conflicts: # app/src/androidTest/java/com/example/cahier/CahierAppTest.kt
cka-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some nit comments
No description provided.