Skip to content

fix: pushPerson parameter #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RuffaloLavoisier wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: pushPerson parameter #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/com/google/android/samples/socialite/repository/ChatRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ class ChatRepository @Inject internal constructor(
timestamp = System.currentTimeMillis(),
),
)
notificationHelper.pushShortcut(detail.firstContact, PushReason.OutgoingMessage)
notificationHelper.pushShortcut(detail.firstContact, pushReason)
Copy link

@gemini-code-assist gemini-code-assist bot Apr 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The change from a fixed PushReason.OutgoingMessage to a parameter pushReason makes the function more versatile. Ensure that all call sites are updated to pass the correct pushReason value. Consider adding a comment explaining the purpose of the pushReason parameter for better readability.

Suggested change
notificationHelper.pushShortcut(detail.firstContact, pushReason)
notificationHelper.pushShortcut(detail.firstContact, pushReason) // Use the provided push reason

}

private suspend fun getMessageHistory(chatId: Long): List<Content> {
Expand Down