Skip to content

fix: center the video player in the landscape mode #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rayworks wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: center the video player in the landscape mode #181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4693f99
fix: center the video player in the landscape mode
rayworks Dec 17, 2025
9184314
Apply padding to the container according to the review feedback
rayworks Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions app/src/main/java/com/google/android/samples/socialite/ui/player/VideoPlayerScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ import android.os.Build
import android.util.Rational
import androidx.activity.ComponentActivity
import androidx.compose.foundation.focusable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.padding
import androidx.compose.material.icons.Icons
Expand All @@ -46,6 +44,7 @@ import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.rememberUpdatedState
import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.toAndroidRectF
Expand Down Expand Up @@ -127,8 +126,13 @@ private fun VideoPlayerScreen(
Scaffold(
topBar = { VideoPlayerTopAppBar(onCloseButtonClicked) },
) { innerPadding ->
Column(modifier = modifier.fillMaxSize(), verticalArrangement = Arrangement.Center) {
VideoPlayer(player, shouldEnterPipMode, Modifier.padding(innerPadding))
Box(
modifier = modifier
.fillMaxSize()
.padding(innerPadding),
contentAlignment = Alignment.Center,
) {
VideoPlayer(player, shouldEnterPipMode)
}
}
}
Expand Down