fix crossplatform pathing in permission wildcards #7283
+224
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
rekram1-node
reviewed
Jan 8, 2026
rekram1-node
reviewed
Jan 8, 2026
Fix permission matching to work correctly on Windows by normalizing path separators to forward slashes before pattern matching. Changes: - Wildcard.match() now normalizes both input and pattern to forward slashes - PermissionNext.fromConfig() normalizes config patterns on load - Added 24 comprehensive tests for Windows path scenarios This allows configs to use either / or \ and work seamlessly across all platforms (Windows, Linux, macOS). Users can paste Windows paths directly into configs without manual conversion. Fixes: Permission patterns like 'openspec/*' now correctly match Windows paths like 'openspec\api.yaml'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rekram1-node here is a quick fix, all changes made in opencode itself
#7279