Skip to content

Conversation

@louhaojie99
Copy link
Member

@louhaojie99 louhaojie99 commented Dec 25, 2025

📝 Description

启动 site 项目,improt @antv/x6 类型报红,处理一下。

🖼️ Screenshot

Before After

💡 Motivation and Context

🧩 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

🔍 Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @louhaojie99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

这个拉取请求旨在解决文档站点项目在开发过程中遇到的 @antv/x6 依赖类型解析错误。通过引入一个专门的 tsconfig.json 文件并配置路径别名,确保了站点项目能够正确识别和使用 @antv/x6 的类型定义,从而修复了启动时的类型报错问题,提升了开发体验。

Highlights

  • 修复类型错误: 解决了文档站点项目启动时,导入 @antv/x6 依赖时出现的类型报错问题。
  • 新增 tsconfig.json 配置: 在 site 目录下新增了 tsconfig.json 文件,用于配置 TypeScript 编译选项。
  • 配置路径别名: 在 tsconfig.json 中配置了 @antv/x6 的路径别名,将其指向本地的 ../src 目录,以正确解析依赖类型。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 通过在 site 目录下添加 tsconfig.json 文件,并配置 paths 来映射 @antv/x6 到其源码目录,成功解决了文档站点在开发时遇到的类型错误问题。这是一个正确的修复方式。我有一个小建议,可以把 site/.dumirc.ts 也包含到 tsconfig 的检查范围中,以保证项目中所有 TypeScript 文件都有一致的类型检查配置。

"noFallthroughCasesInSwitch": true,
"baseUrl": ".",
"paths": {
"@antv/x6": ["../src"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"../lib" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参考的 examples 的 tsconfig

image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants