-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: 修复文档站点项目引用 @antv/x6 依赖类型错误 #4984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @louhaojie99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 这个拉取请求旨在解决文档站点项目在开发过程中遇到的 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 通过在 site 目录下添加 tsconfig.json 文件,并配置 paths 来映射 @antv/x6 到其源码目录,成功解决了文档站点在开发时遇到的类型错误问题。这是一个正确的修复方式。我有一个小建议,可以把 site/.dumirc.ts 也包含到 tsconfig 的检查范围中,以保证项目中所有 TypeScript 文件都有一致的类型检查配置。
| "noFallthroughCasesInSwitch": true, | ||
| "baseUrl": ".", | ||
| "paths": { | ||
| "@antv/x6": ["../src"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"../lib" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.


📝 Description
启动 site 项目,improt @antv/x6 类型报红,处理一下。
🖼️ Screenshot
💡 Motivation and Context
🧩 Types of changes
🔍 Self Check before Merge