Skip to content

Conversation

@Kidcredible300
Copy link
Contributor

Works on resolving #77

@Kidcredible300
Copy link
Contributor Author

I originally included a test using null options for the CompressionConfigurer, which should be supported (see line 420 of ProxyServer.java). However, the test times out—likely because that line isn’t behaving as expected. The stack trace suggests it’s waiting for data that never arrives. This might warrant a separate issue, and it could also point to a similar problem with null options for the CompactionSelector.

@Kidcredible300 Kidcredible300 marked this pull request as ready for review July 17, 2025 20:40
@ddanielr ddanielr self-requested a review July 18, 2025 22:06
Copy link
Contributor

@keith-turner keith-turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test looks good, does it run ok?

Based on suggestion from Keith Turner, added another check for sizes2.
@ddanielr ddanielr merged commit 894d8c8 into apache:main Sep 15, 2025
2 checks passed
@ddanielr ddanielr linked an issue Sep 17, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test coverage for CompactionConfigurer

4 participants