Skip to content

Fix: Add accessible titles to comparison table icons #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huangkevin-apr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Add accessible titles to comparison table icons #1985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions website/src/components/sections/Comparison.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,33 +50,33 @@ const Comparison: FC = () => (
</tr>
<tr>
<th scope="row">Dubbo, MQTT, Tengine and REST API to gRPC transcoding</th>
<td><Tick /></td>
<td><Cross /></td>
<td><Tick title="Supported" /></td>
<td><Cross title="Not supported" /></td>
</tr>
<tr>
<th scope="row">Configuration rollback</th>
<td><Tick /></td>
<td><Cross /></td>
<td><Tick title="Supported" /></td>
<td><Cross title="Not supported" /></td>
</tr>
<tr>
<th scope="row">Custom Load Balancing and routing</th>
<td><Tick /></td>
<td><Cross /></td>
<td><Tick title="Supported" /></td>
<td><Cross title="Not supported" /></td>
</tr>
<tr>
<th scope="row">Plugin hot loading</th>
<td><Tick /></td>
<td><Cross /></td>
<td><Tick title="Supported" /></td>
<td><Cross title="Not supported" /></td>
</tr>
<tr>
<th scope="row">Dashboard</th>
<td><Tick /></td>
<td><Cross /></td>
<td><Tick title="Supported" /></td>
<td><Cross title="Not supported" /></td>
</tr>
<tr>
<th scope="row">Support any NGINX variable as routing condition</th>
<td><Tick /></td>
<td><Cross /></td>
<td><Tick title="Supported" /></td>
<td><Cross title="Not supported" /></td>
</tr>
</tbody>
</table>
Expand Down
Loading