fix: [9018]Fixed RunArray slice offsets(row, cast, eq) #9213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishkr
force-pushed
the
9018-fix-runarray-kernel-issues
branch
from
14f94b2 to
da01470
Compare
Jefffrey
reviewed
Jan 21, 2026
manishkr
force-pushed
the
9018-fix-runarray-kernel-issues
branch
from
da01470 to
5842759
Compare
Jefffrey
reviewed
Jan 24, 2026
manishkr
force-pushed
the
9018-fix-runarray-kernel-issues
branch
from
5842759 to
862378d
Compare
Jefffrey
approved these changes
Jan 26, 2026
Contributor
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
This looks quite good; thanks for the comments explaining the logic in the equal implementation 👍
| let r_runs = r_end_phys - r_start_phys + 1; | ||
|
|
||
| if l_runs == r_runs { | ||
| // When the boundaries align perfectly, we don't need the complex stepping loop that calculates overlaps. |
Contributor
There was a problem hiding this comment.
Thanks for these comments, they really helped my understanding of this code 👍
manishkr
force-pushed
the
9018-fix-runarray-kernel-issues
branch
from
862378d to
9647a93
Compare
Contributor
Contributor
brancz
approved these changes
Jan 27, 2026
Contributor
brancz
left a comment
brancz
left a comment
There was a problem hiding this comment.
Very cool! I'm generally happy with this implementation, but without having thought about it too much, I think this implementation may not be very auto-vectorizable by the compiler. Maybe it's impossible, or even not important, since ranges are already covered, but perhaps something to think about for future optimizations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
RunArrays #9018 .Rationale for this change
The existing implementation had issue for row or cast ops for RunArray. The equality implementation also did not support logical index-based comparisons.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No.