optimize RowGroupIndexReader for single row group reads
#9226
+153
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
approved these changes
Jan 20, 2026
Contributor
|
@friendlymatthew do you have some performance results? |
Contributor
|
@friendlymatthew are you able to answer @Dandandan questions about performance benchmarks? |
Contributor
Author
Hi, yes. I am afk these next two weeks so am slow to respond. But will try to get it done before then! |
Contributor
|
Sounds good -- thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
RowGroupIndexReaderfor single row group reads #9180Rationale for this change
This PR adds a fast path that detects single row group reads at construction time and stores the constant index value directly, avoiding Hashmap allocation and iterator overhead
For multiple row groups, the existing iterator-based approach is used unchanged