Skip to content

Conversation

@Dandandan
Copy link
Contributor

Which issue does this PR close?

  • Closes #NNN.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Jan 23, 2026
@Dandandan
Copy link
Contributor Author

run benchmarks arrow_reader_clickbench

@alamb-ghbot
Copy link

🤖 Hi @Dandandan, thanks for the request (#9256 (comment)).

scrape_comments.py only supports whitelisted benchmarks.

  • Standard: (none)
  • Criterion: array_iter, arrow_reader, arrow_reader_clickbench, arrow_reader_row_filter, arrow_statistics, arrow_writer, bitwise_kernel, boolean_kernels, buffer_bit_ops, cast_kernels, coalesce_kernels, comparison_kernels, concatenate_kernel, csv_writer, encoding, filter_kernels, interleave_kernels, json-reader, metadata, row_format, take_kernels, union_array, variant_builder, variant_kernels, variant_validation, view_types, zip_kernels

Please choose one or more of these with run benchmark <name> or run benchmark <name1> <name2>...

@Dandandan
Copy link
Contributor Author

run benchmark arrow_reader_clickbench

@alamb-ghbot
Copy link

🤖 ./gh_compare_arrow.sh gh_compare_arrow.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing upgrade_object_store (3ad6b1f) to bd76edd diff
BENCH_NAME=arrow_reader_clickbench
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_reader_clickbench
BENCH_FILTER=
BENCH_BRANCH_NAME=upgrade_object_store
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

group                                             main                                   upgrade_object_store
-----                                             ----                                   --------------------
arrow_reader_clickbench/async/Q1                  1.02      2.4±0.07ms        ? ?/sec    1.00      2.4±0.05ms        ? ?/sec
arrow_reader_clickbench/async/Q10                 1.00     10.9±0.51ms        ? ?/sec    1.23     13.4±0.43ms        ? ?/sec
arrow_reader_clickbench/async/Q11                 1.00     12.6±0.26ms        ? ?/sec    1.21     15.2±0.46ms        ? ?/sec
arrow_reader_clickbench/async/Q12                 1.00     22.3±0.42ms        ? ?/sec    1.07     24.0±0.36ms        ? ?/sec
arrow_reader_clickbench/async/Q13                 1.00     28.2±0.81ms        ? ?/sec    1.05     29.6±0.44ms        ? ?/sec
arrow_reader_clickbench/async/Q14                 1.00     25.2±0.29ms        ? ?/sec    1.05     26.5±0.31ms        ? ?/sec
arrow_reader_clickbench/async/Q19                 1.00      5.4±0.07ms        ? ?/sec    1.17      6.3±0.24ms        ? ?/sec
arrow_reader_clickbench/async/Q20                 1.13    130.4±1.20ms        ? ?/sec    1.00    115.8±2.10ms        ? ?/sec
arrow_reader_clickbench/async/Q21                 1.25    164.5±1.61ms        ? ?/sec    1.00    131.8±1.86ms        ? ?/sec
arrow_reader_clickbench/async/Q22                 1.00   259.7±35.95ms        ? ?/sec    1.06   275.3±12.82ms        ? ?/sec
arrow_reader_clickbench/async/Q23                 1.00    412.3±3.73ms        ? ?/sec    1.01    415.3±4.24ms        ? ?/sec
arrow_reader_clickbench/async/Q24                 1.00     30.8±0.60ms        ? ?/sec    1.01     31.3±0.71ms        ? ?/sec
arrow_reader_clickbench/async/Q27                 1.02    100.5±0.75ms        ? ?/sec    1.00     98.7±1.47ms        ? ?/sec
arrow_reader_clickbench/async/Q28                 1.01     98.4±1.10ms        ? ?/sec    1.00     97.1±0.91ms        ? ?/sec
arrow_reader_clickbench/async/Q30                 1.00     27.3±0.57ms        ? ?/sec    1.00     27.4±0.49ms        ? ?/sec
arrow_reader_clickbench/async/Q36                 1.02    109.3±0.77ms        ? ?/sec    1.00    107.2±1.04ms        ? ?/sec
arrow_reader_clickbench/async/Q37                 1.02     85.1±0.65ms        ? ?/sec    1.00     83.7±1.32ms        ? ?/sec
arrow_reader_clickbench/async/Q38                 1.02     33.3±0.27ms        ? ?/sec    1.00     32.6±0.74ms        ? ?/sec
arrow_reader_clickbench/async/Q39                 1.03     46.8±0.57ms        ? ?/sec    1.00     45.6±0.45ms        ? ?/sec
arrow_reader_clickbench/async/Q40                 1.03     28.4±0.69ms        ? ?/sec    1.00     27.5±0.67ms        ? ?/sec
arrow_reader_clickbench/async/Q41                 1.02     22.7±0.53ms        ? ?/sec    1.00     22.2±0.46ms        ? ?/sec
arrow_reader_clickbench/async/Q42                 1.02     11.0±0.16ms        ? ?/sec    1.00     10.7±0.23ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q1     1.03      2.3±0.03ms        ? ?/sec    1.00      2.3±0.02ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q10    1.00     10.4±0.35ms        ? ?/sec    1.00     10.4±0.11ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q11    1.00     12.0±0.48ms        ? ?/sec    1.00     12.0±0.30ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q12    1.01     21.6±0.37ms        ? ?/sec    1.00     21.5±0.33ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q13    1.01     26.4±0.43ms        ? ?/sec    1.00     26.3±0.33ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q14    1.01     24.3±0.28ms        ? ?/sec    1.00     24.0±0.38ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q19    1.02      5.1±0.07ms        ? ?/sec    1.00      5.0±0.11ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q20    1.02    110.6±0.93ms        ? ?/sec    1.00    108.6±1.42ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q21    1.02    126.3±1.51ms        ? ?/sec    1.00    124.0±0.68ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q22    1.02    231.4±1.72ms        ? ?/sec    1.00    227.3±1.42ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q23    1.04    356.5±2.04ms        ? ?/sec    1.00    342.4±2.57ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q24    1.00     29.2±0.37ms        ? ?/sec    1.00     29.2±0.38ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q27    1.02     95.8±0.76ms        ? ?/sec    1.00     93.8±1.04ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q28    1.01     93.7±0.55ms        ? ?/sec    1.00     92.6±0.76ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q30    1.02     26.6±0.44ms        ? ?/sec    1.00     26.2±0.55ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q36    1.02    104.2±0.90ms        ? ?/sec    1.00    102.1±0.75ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q37    1.02     81.7±0.61ms        ? ?/sec    1.00     80.2±1.37ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q38    1.04     30.2±0.37ms        ? ?/sec    1.00     29.1±0.53ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q39    1.02     41.1±0.37ms        ? ?/sec    1.00     40.4±0.89ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q40    1.02     26.3±0.33ms        ? ?/sec    1.00     25.9±0.57ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q41    1.01     21.0±0.32ms        ? ?/sec    1.00     20.7±0.52ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q42    1.02     10.4±0.10ms        ? ?/sec    1.00     10.2±0.13ms        ? ?/sec
arrow_reader_clickbench/sync/Q1                   1.00      2.1±0.03ms        ? ?/sec    1.00      2.1±0.06ms        ? ?/sec
arrow_reader_clickbench/sync/Q10                  1.02      7.9±0.24ms        ? ?/sec    1.00      7.7±0.07ms        ? ?/sec
arrow_reader_clickbench/sync/Q11                  1.02      9.4±0.06ms        ? ?/sec    1.00      9.3±0.19ms        ? ?/sec
arrow_reader_clickbench/sync/Q12                  1.00     28.3±0.50ms        ? ?/sec    1.18     33.3±1.32ms        ? ?/sec
arrow_reader_clickbench/sync/Q13                  1.05     42.8±1.24ms        ? ?/sec    1.00     40.6±2.50ms        ? ?/sec
arrow_reader_clickbench/sync/Q14                  1.00     30.6±0.60ms        ? ?/sec    1.00     30.7±0.66ms        ? ?/sec
arrow_reader_clickbench/sync/Q19                  1.03      4.3±0.10ms        ? ?/sec    1.00      4.2±0.05ms        ? ?/sec
arrow_reader_clickbench/sync/Q20                  1.02    176.9±1.30ms        ? ?/sec    1.00    172.8±1.05ms        ? ?/sec
arrow_reader_clickbench/sync/Q21                  1.06    233.5±1.74ms        ? ?/sec    1.00    220.8±2.66ms        ? ?/sec
arrow_reader_clickbench/sync/Q22                  1.02    478.4±4.44ms        ? ?/sec    1.00    468.2±3.38ms        ? ?/sec
arrow_reader_clickbench/sync/Q23                  1.02   439.3±20.70ms        ? ?/sec    1.00   431.3±14.93ms        ? ?/sec
arrow_reader_clickbench/sync/Q24                  1.00     38.6±0.49ms        ? ?/sec    1.09     42.2±1.36ms        ? ?/sec
arrow_reader_clickbench/sync/Q27                  1.00    153.8±1.86ms        ? ?/sec    1.03    158.4±4.89ms        ? ?/sec
arrow_reader_clickbench/sync/Q28                  1.00    148.6±1.07ms        ? ?/sec    1.03    153.5±2.40ms        ? ?/sec
arrow_reader_clickbench/sync/Q30                  1.00     27.7±0.40ms        ? ?/sec    1.08     30.0±0.72ms        ? ?/sec
arrow_reader_clickbench/sync/Q36                  1.00    153.7±1.48ms        ? ?/sec    1.04    159.3±1.86ms        ? ?/sec
arrow_reader_clickbench/sync/Q37                  1.00     87.3±2.18ms        ? ?/sec    1.03     90.2±0.91ms        ? ?/sec
arrow_reader_clickbench/sync/Q38                  1.00     29.3±0.33ms        ? ?/sec    1.02     29.9±0.43ms        ? ?/sec
arrow_reader_clickbench/sync/Q39                  1.00     34.1±0.39ms        ? ?/sec    1.07     36.3±0.82ms        ? ?/sec
arrow_reader_clickbench/sync/Q40                  1.00     26.5±0.34ms        ? ?/sec    1.08     28.5±0.62ms        ? ?/sec
arrow_reader_clickbench/sync/Q41                  1.00     29.3±0.77ms        ? ?/sec    1.06     31.1±0.50ms        ? ?/sec
arrow_reader_clickbench/sync/Q42                  1.00     12.4±0.10ms        ? ?/sec    1.04     12.9±0.33ms        ? ?/sec

@Dandandan Dandandan marked this pull request as ready for review January 23, 2026 23:34
Copy link
Contributor

@mhilton mhilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jefffrey
Copy link
Contributor

Would this supersede

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants