Skip to content

Conversation

@liamzwbao
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Add tests of path index access for list in variant_get to address the comment #9049 (review)

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the parquet-variant parquet-variant* crates label Jan 26, 2026
@liamzwbao
Copy link
Contributor Author

Hi @klion26 @alamb, a small PR to add tests for variant_get. PTAL, thanks!

@liamzwbao liamzwbao marked this pull request as ready for review January 26, 2026 23:55
@liamzwbao liamzwbao force-pushed the issue-8082-variant-get-list-tests branch from 7141080 to 86e72d8 Compare January 27, 2026 00:01
Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet-variant parquet-variant* crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants