Skip to content

Conversation

@lichuang
Copy link
Contributor

Which issue does this PR close?

fix: fix [[NULL]] array doesn't roundtrip in arrow-row bug

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 27, 2026
@Jefffrey
Copy link
Contributor

Thanks for volunteering to pick up this issue. I'm concerned this doesn't properly address the root cause; for example this case would also fail:

    #[test]
    fn test_nested_null_list() {
        let null_array = Arc::new(NullArray::new(3));
        // [[NULL], [], [NULL, NULL]]
        let list: ArrayRef = Arc::new(ListArray::new(
            Field::new_list_field(DataType::Null, true).into(),
            OffsetBuffer::from_lengths(vec![1, 0, 2]),
            null_array,
            None,
        ));

        let converter = RowConverter::new(vec![SortField::new(list.data_type().clone())]).unwrap();
        let rows = converter.convert_columns(&[Arc::clone(&list)]).unwrap();
        let back = converter.convert_rows(&rows).unwrap();

        assert_eq!(&list, &back[0]);
    }

Can check my comments on the original issue to perhaps try do deeper/root cause fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[[NULL]] array doesn't roundtrip in arrow-row

2 participants