Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jan 27, 2026

Which issue does this PR close?

Rationale for this change

As we go about implementing the changes in

I am really struggling to be convinced that the logic for multi-column page skipping is accurate. Thus I am working on adding additional test coverage

What changes are included in this PR?

Add additional test coverage for multi-column row filter predicates

TODO more tests

  • different projections
  • Two row filters
  • different cursor strategies
  • Randomized selection testing

Are these changes tested?

Yes, with CI

Are there any user-facing changes?

No

@github-actions github-actions bot added the parquet Changes to the parquet crate label Jan 27, 2026
Copy link
Contributor

@sdf-jkl sdf-jkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good

@alamb
Copy link
Contributor Author

alamb commented Jan 27, 2026

This looks really good

Thank you -- I am getting there. I need to add a few more combinations and then I expect to start hitting some of the bugs

@alamb
Copy link
Contributor Author

alamb commented Jan 27, 2026

Update: the tests are coming along, but they are not yet at the state where they reproduce the issue yet (I believe doing so requires more than one arrow predicate)

i need to catch up on other reviews, etc today now, but I will get back to these tests tomorrow and hopefully finish them up (and then get back to the actual PR !)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants