parquet: reduce clone in delta byte array decoder #9282
+8
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
small optimization
Rationale for this change
key insight is the byte clone is cheap just a ref count compare to vec clone is a alloc + memcopy.
before
after
What changes are included in this PR?
previous_value type changed to Bytes
preallocate result vec capacity.
Are these changes tested?
the existing test should pass
Are there any user-facing changes?
no