fix union array row converter to handle non-sequential type ids #9283
+88
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friendlymatthew
commented
Jan 27, 2026
Contributor
Author
friendlymatthew
left a comment
friendlymatthew
left a comment
There was a problem hiding this comment.
self review
Comment on lines
+504
to
+506
| /// Row converters for each union field (indexed by field position) | ||
| /// the type_ids for each field position, and the encoding of null rows for each field | ||
| Union(Vec<RowConverter>, Vec<i8>, Vec<OwnedRow>), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
RowConverterpanics when encoding union array with non-default type IDs #9263Rationale for this change
This PR fixes the row converter's handling of union arrays with non-sequential type ids.
Previously, type ids were incorrectly used as array indices into the converters vector, causing panics or data corruption when type ids didn't match field positions. The fix was to add a mapping from type ids to field indices