Skip to content

Conversation

@alinaliBQ
Copy link
Contributor

@alinaliBQ alinaliBQ commented Dec 18, 2025

Rationale for this change

#48594

What changes are included in this PR?

  • Resolve caching issue inside ODBC CI, so build time is generally less than 1hr
  • Removed environment variables that are not necessary for ODBC building to keep workflow simple

Are these changes tested?

  • Tested in CI

Are there any user-facing changes?

N/A

@github-actions
Copy link

⚠️ GitHub issue #48594 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Dec 18, 2025
Add write permission to store vcpkg cache
@alinaliBQ alinaliBQ force-pushed the gh-48594-fix-msvc-ci branch 6 times, most recently from 33227e6 to 6efa7d4 Compare December 18, 2025 23:07
Run vcpkg install after vcpkg is set in GLib
* confirmed `vcpkg install` command returns 403 error
Remove `ARROW_SIMD_LEVEL` as it is not required for ODBC.
Cannot get vcpkg in cpp_build to show debug messages
@alinaliBQ
Copy link
Contributor Author

Hi @pitrou and @raulcd, to follow up on #48313 I have opened this draft PR.

As Raul has pointed out in #48313 (comment), there is an issue pushing the packages to nuget. Therefore, when a new ODBC build begins, all vcpkg packages are rebuilt and that is the root cause of the long ODBC build time.

Does it require any changes in the GitHub repository settings to allow the new workflow to push packages to https://nuget.pkg.github.com/apache?

@alinaliBQ
Copy link
Contributor Author

alinaliBQ commented Dec 19, 2025

During investigation, I tried running vcpkg install command before the cpp_build.sh script in C GLib & Ruby MSVC workflow, and it has the same 403 error as ODBC MSVC. But the script cpp_build.sh in GLib workflow can still publish nuget packages normally. I am not sure why the same script works in GLib MSVC, but not in ODBC MSVC.
Run log: https://github.com/apache/arrow/actions/runs/20353354024/job/58483242851?pr=48595#step:13:3353

@alinaliBQ alinaliBQ force-pushed the gh-48594-fix-msvc-ci branch 5 times, most recently from 0bb3f77 to 896309c Compare December 19, 2025 22:03
@alinaliBQ alinaliBQ force-pushed the gh-48594-fix-msvc-ci branch from 896309c to e608216 Compare December 19, 2025 22:07
@alinaliBQ alinaliBQ force-pushed the gh-48594-fix-msvc-ci branch from e608216 to dfea377 Compare December 19, 2025 22:15
Push after previous run is complete.
@alinaliBQ alinaliBQ force-pushed the gh-48594-fix-msvc-ci branch from d0d1b4a to 0e31acb Compare December 20, 2025 00:10
@alinaliBQ alinaliBQ force-pushed the gh-48594-fix-msvc-ci branch from 0e31acb to 0c911a5 Compare December 20, 2025 00:14
@alinaliBQ alinaliBQ changed the title GH-48594: [C++][FlightRPC] Fix ODBC CI Caching Issue GH-48594: [C++][FlightRPC] Fix ODBC CI Nuget Package Upload Issue Dec 20, 2025
@alinaliBQ alinaliBQ changed the title GH-48594: [C++][FlightRPC] Fix ODBC CI Nuget Package Upload Issue GH-48594: [C++][FlightRPC] Fix ODBC CI Long Build Time Issue Dec 20, 2025
@alinaliBQ
Copy link
Contributor Author

alinaliBQ commented Dec 20, 2025

ODBC build time has been reduced to around 40 - 60 mins. PR is ready for review. Raised an issue for the flakey 403 request error #48604. Raised #48606 for nuget push timeout issue.

@alinaliBQ alinaliBQ marked this pull request as ready for review December 20, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review Awaiting review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant